Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency jsdom to v24 #233

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 26, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
jsdom ^23.0.0 -> ^24.0.0 age adoption passing confidence

Release Notes

jsdom/jsdom (jsdom)

v24.0.0

Compare Source

This release reverts our selector engine back to nwsapi. As discussed in #​3659, the performance regressions from @asamuzakjp/dom-selector turned out to be higher than anticipated. In the future, we can revisit @asamuzakjp/dom-selector after it reaches nwsapi's performance on the two real-world benchmarks provided by the community.

Since reverting to nwsapi causes several functionality regressions, e.g. removing :has() support, we've decided to make this a major version.

Additionally:

  • Small fixes to edge-case behavior of the following properties: input.maxLength, input.minLength, input.size, progress.max, tableCell.colSpan, tableCell.rowSpan, tableCol.span, textArea.cols, textArea.maxLength, textArea.minLength, textArea.rows.

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.


Thanks for the PR!

Any successful deployments (not always required) will be available below.

Backend: https://nr-silva-33-backend.apps.silver.devops.gov.bc.ca/actuator/health
Frontend: https://nr-silva-33-frontend.apps.silver.devops.gov.bc.ca

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@renovate renovate bot enabled auto-merge (squash) January 26, 2024 01:01
@renovate renovate bot force-pushed the renovate/jsdom-24.x branch 2 times, most recently from dcff747 to 96f643f Compare January 26, 2024 01:28
@renovate renovate bot force-pushed the renovate/jsdom-24.x branch from 96f643f to 93c22a2 Compare January 26, 2024 03:45
Copy link
Contributor Author

renovate bot commented Jan 29, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

Copy link

@RMCampos RMCampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Everything working nicely.

@renovate renovate bot merged commit bdc10a0 into main Jan 29, 2024
14 checks passed
@renovate renovate bot deleted the renovate/jsdom-24.x branch January 29, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant