Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: steps unit tests #109

Merged
merged 8 commits into from
May 15, 2023
Merged

Feat: steps unit tests #109

merged 8 commits into from
May 15, 2023

Conversation

lucasbuenoencora
Copy link
Contributor

@lucasbuenoencora lucasbuenoencora commented May 11, 2023

Description

Implementation of unit tests for seedlot registration steps and remove unnecessary files from testing coverage

Implements FSADT2-640

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Manually tested by test(jest) command

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend
Frontend
Oracle-API

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

Copy link
Contributor

@RMCampos RMCampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!! 🥇 🥳

@lucasbuenoencora lucasbuenoencora merged commit 8fcaf26 into main May 15, 2023
@lucasbuenoencora lucasbuenoencora deleted the feat/steps_unit_tests branch May 15, 2023 14:40
DerekRoberts added a commit that referenced this pull request May 13, 2024
* feat: add steps unit tests and add coveragePathIgnorePatterns in the jest config file

* feat: add mock server to unit tests

* feat: add new unit tests and commented console warning of FavouriteActivities

---------

Co-authored-by: Derek Roberts <derek.roberts@gmail.com>
Co-authored-by: Craig Yu <craig.yu93@gmail.com>
DerekRoberts added a commit that referenced this pull request May 14, 2024
* feat: add steps unit tests and add coveragePathIgnorePatterns in the jest config file

* feat: add mock server to unit tests

* feat: add new unit tests and commented console warning of FavouriteActivities

---------

Co-authored-by: Derek Roberts <derek.roberts@gmail.com>
Co-authored-by: Craig Yu <craig.yu93@gmail.com>
DerekRoberts added a commit that referenced this pull request May 14, 2024
* feat: add steps unit tests and add coveragePathIgnorePatterns in the jest config file

* feat: add mock server to unit tests

* feat: add new unit tests and commented console warning of FavouriteActivities

---------

Co-authored-by: Derek Roberts <derek.roberts@gmail.com>
Co-authored-by: Craig Yu <craig.yu93@gmail.com>
DerekRoberts added a commit that referenced this pull request May 14, 2024
* feat: add steps unit tests and add coveragePathIgnorePatterns in the jest config file

* feat: add mock server to unit tests

* feat: add new unit tests and commented console warning of FavouriteActivities

---------

Co-authored-by: Derek Roberts <derek.roberts@gmail.com>
Co-authored-by: Craig Yu <craig.yu93@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants