Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation fixes #125

Merged
merged 3 commits into from
May 17, 2023
Merged

Navigation fixes #125

merged 3 commits into from
May 17, 2023

Conversation

ArthurEncr
Copy link
Contributor

@ArthurEncr ArthurEncr commented May 16, 2023 •
edited by github-actions bot
Loading

Description

Bug fix for two navigation problems (in my seedlots table and in the specific seedlot page)

Fixes FSADT2-608 and FSADT2-617

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend
Frontend
Oracle-API

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

craigyu
craigyu approved these changes May 16, 2023
View reviewed changes
Copy link
Collaborator

@craigyu craigyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, such a quality of life improvement!

RMCampos
RMCampos approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@RMCampos RMCampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! ✅

frontend/src/views/Seedlot/MySeedlots/SeedlotDataTable/index.tsx Show resolved Hide resolved
frontend/src/views/Seedlot/SeedlotDetails/index.tsx Show resolved Hide resolved
@ArthurEncr ArthurEncr merged commit f961f5b into main May 17, 2023
@ArthurEncr ArthurEncr deleted the navigation-fixes branch May 17, 2023 16:32
DerekRoberts pushed a commit that referenced this pull request May 13, 2024
@ArthurEncr @DerekRoberts
Navigation fixes (#125)
79d4f22 
* fix: fixing breadcrumb link

* fix: fixing open seedlot details screen when click on table
DerekRoberts pushed a commit that referenced this pull request May 14, 2024
@ArthurEncr @DerekRoberts
Navigation fixes (#125)
3c14e16 
* fix: fixing breadcrumb link

* fix: fixing open seedlot details screen when click on table
DerekRoberts pushed a commit that referenced this pull request May 14, 2024
@ArthurEncr @DerekRoberts
Navigation fixes (#125)
f380f78 
* fix: fixing breadcrumb link

* fix: fixing open seedlot details screen when click on table
DerekRoberts pushed a commit that referenced this pull request May 14, 2024
@ArthurEncr @DerekRoberts
Navigation fixes (#125)
6b04219 
* fix: fixing breadcrumb link

* fix: fixing open seedlot details screen when click on table
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craigyu craigyu craigyu approved these changes

@RMCampos RMCampos RMCampos approved these changes

@SLDonnelly SLDonnelly Awaiting requested review from SLDonnelly SLDonnelly is a code owner

@DerekRoberts DerekRoberts Awaiting requested review from DerekRoberts DerekRoberts is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArthurEncr @RMCampos @craigyu