Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ui issues and improvements pt. 2 #1458

Merged
merged 26 commits into from
Aug 12, 2024

Conversation

mgaseta
Copy link
Collaborator

@mgaseta mgaseta commented Jul 31, 2024

Description

Fixes partially #1388
Fix issues:

Other issues fixed:

  • Breadcrumbs cursor to pointers
  • Seedlot tables skeletons hiding headers

Changelog

New

  • Lots of styles :)

Changed

  • Made total-counts header visible on the BE
  • Styles on the client search modal
  • Validation for current menu on the header
  • Notification component for submit modal
  • Step 6 date fields on review
  • Action button on seedlot details page
  • Minor texts and styles

Removed

  • Nothing :)

How was this tested?

  • 🧠 Not needed
  • 👀 Eyeball
  • 🤖 Added tests

What gif/image best describes this PR or how it makes you feel?


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@mgaseta mgaseta requested a review from ngunner15 July 31, 2024 20:46
@mgaseta mgaseta self-assigned this Jul 31, 2024
@mgaseta mgaseta linked an issue Jul 31, 2024 that may be closed by this pull request
Copy link
Collaborator

@ngunner15 ngunner15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM💯

Copy link
Collaborator

@craigyu craigyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE, just one typo

should we get @mmarsoleta to review and approve the UI changes?

@mmarsoleta
Copy link

NICE, just one typo

should we get @mmarsoleta to review and approve the UI changes?

sure, just let me know when I can review it again, and the link please 🥳

@mgaseta
Copy link
Collaborator Author

mgaseta commented Aug 12, 2024

Talked with @mmarsoleta and everything is fine!

@craigyu craigyu merged commit 5fe2642 into main Aug 12, 2024
26 of 28 checks passed
@craigyu craigyu deleted the fix/388-seedlot-registration-test-uiux-issues branch August 12, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seedlot registration test: UI/UX Issues
4 participants