generated from bcgov/quickstart-openshift
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker Compose adjustments #147
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
May 18, 2023
DerekRoberts
requested review from
craigyu,
RMCampos and
SLDonnelly
as code owners
May 18, 2023 00:25
DerekRoberts
force-pushed
the
feat/dcFrontendTweaks
branch
from
May 18, 2023 18:46
1bf05f8
to
e278635
Compare
DerekRoberts
force-pushed
the
feat/dcFrontendTweaks
branch
from
May 18, 2023 20:08
82e3a6b
to
e278635
Compare
craigyu
approved these changes
May 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
working nicely, my file survived!
DerekRoberts
added a commit
that referenced
this pull request
May 13, 2024
* Frontend up yarn installs * Consolidate Healthchecks into Dockerfiles * Make oracle-api depend on backend * Unprivileged user for local frontend dev * Use default values for healthchecks * Formatting, slight logic tweak * Let local frontend use user:root
DerekRoberts
added a commit
that referenced
this pull request
May 14, 2024
* Frontend up yarn installs * Consolidate Healthchecks into Dockerfiles * Make oracle-api depend on backend * Unprivileged user for local frontend dev * Use default values for healthchecks * Formatting, slight logic tweak * Let local frontend use user:root
DerekRoberts
added a commit
that referenced
this pull request
May 14, 2024
* Frontend up yarn installs * Consolidate Healthchecks into Dockerfiles * Make oracle-api depend on backend * Unprivileged user for local frontend dev * Use default values for healthchecks * Formatting, slight logic tweak * Let local frontend use user:root
DerekRoberts
added a commit
that referenced
this pull request
May 14, 2024
* Frontend up yarn installs * Consolidate Healthchecks into Dockerfiles * Make oracle-api depend on backend * Unprivileged user for local frontend dev * Use default values for healthchecks * Formatting, slight logic tweak * Let local frontend use user:root
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidate Docker Compose and Dockerfile Healthchecks into just Dockerfiles.
Small adjustment to keep ./node_modules local.
Thanks for the PR!
Any successful deployments (not always required) will be available below.
Backend
Frontend
Oracle-API
Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow