Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Compose adjustments #147

Merged
merged 7 commits into from
May 18, 2023
Merged

Docker Compose adjustments #147

merged 7 commits into from
May 18, 2023

Conversation

DerekRoberts
Copy link
Member

@DerekRoberts DerekRoberts commented May 17, 2023

Consolidate Docker Compose and Dockerfile Healthchecks into just Dockerfiles.

Small adjustment to keep ./node_modules local.


Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend
Frontend
Oracle-API

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@DerekRoberts DerekRoberts self-assigned this May 18, 2023
@DerekRoberts DerekRoberts marked this pull request as ready for review May 18, 2023 00:25
frontend/Dockerfile.dev Fixed Show fixed Hide fixed
@DerekRoberts DerekRoberts marked this pull request as draft May 18, 2023 18:45
@DerekRoberts DerekRoberts force-pushed the feat/dcFrontendTweaks branch from 1bf05f8 to e278635 Compare May 18, 2023 18:46
@DerekRoberts DerekRoberts marked this pull request as ready for review May 18, 2023 19:36
@DerekRoberts DerekRoberts force-pushed the feat/dcFrontendTweaks branch from 82e3a6b to e278635 Compare May 18, 2023 20:08
Copy link
Collaborator

@craigyu craigyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working nicely, my file survived!

@DerekRoberts DerekRoberts merged commit b2af61b into main May 18, 2023
@DerekRoberts DerekRoberts deleted the feat/dcFrontendTweaks branch May 18, 2023 22:18
DerekRoberts added a commit that referenced this pull request May 13, 2024
* Frontend up yarn installs

* Consolidate Healthchecks into Dockerfiles

* Make oracle-api depend on backend

* Unprivileged user for local frontend dev

* Use default values for healthchecks

* Formatting, slight logic tweak

* Let local frontend use user:root
DerekRoberts added a commit that referenced this pull request May 14, 2024
* Frontend up yarn installs

* Consolidate Healthchecks into Dockerfiles

* Make oracle-api depend on backend

* Unprivileged user for local frontend dev

* Use default values for healthchecks

* Formatting, slight logic tweak

* Let local frontend use user:root
DerekRoberts added a commit that referenced this pull request May 14, 2024
* Frontend up yarn installs

* Consolidate Healthchecks into Dockerfiles

* Make oracle-api depend on backend

* Unprivileged user for local frontend dev

* Use default values for healthchecks

* Formatting, slight logic tweak

* Let local frontend use user:root
DerekRoberts added a commit that referenced this pull request May 14, 2024
* Frontend up yarn installs

* Consolidate Healthchecks into Dockerfiles

* Make oracle-api depend on backend

* Unprivileged user for local frontend dev

* Use default values for healthchecks

* Formatting, slight logic tweak

* Let local frontend use user:root
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

One docker compose file for all components Develop in Docker Compose
2 participants