Fix/172 css grid restyling #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-parent-tree-tables-v2
…-parent-tree-tables-v2
…-parent-tree-tables-v2
…-parent-tree-tables-v2
Closed
mgaseta
requested changes
May 30, 2023
frontend/src/components/SeedlotRegistrationSteps/CollectionStep/index.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/SeedlotRegistrationSteps/CollectionStep/index.tsx
Show resolved
Hide resolved
|
As @mgaseta pointed out, this PR contains some changes for the parent tree step component which do not fit the scope of this issue. The reason being this task was branched out of the development of parent tree, in the future this practice will be avoided. For "efficiency" sake, these changes will be pushed to |
mgaseta
requested changes
May 30, 2023
frontend/src/components/SeedlotRegistrationSteps/CollectionStep/index.tsx
Show resolved
Hide resolved
DerekRoberts
pushed a commit
that referenced
this pull request
May 13, 2024
* fix: add prevent duplicate logic to orcahrd step * fix: remove prevent duplicate orchard id logic * fix: modularize things * fix: add root to dockerfile dev * feat: add DescriptionBox component * feat: adjust description box styling * fix: update carbon version * fix: test link in notification box * fix: remove !import for grid and refactor related code * feat: add padding to page bottom * fix: change where padding bottom is added * feat: add btn text and icon customization feat to submit modal * fix: update snapshot * fix: add end of file lines * fix: fix collection start date col size * fix: update em to rem * fix: add breakpoints to col * fix: update to rem
DerekRoberts
pushed a commit
that referenced
this pull request
May 14, 2024
* fix: add prevent duplicate logic to orcahrd step * fix: remove prevent duplicate orchard id logic * fix: modularize things * fix: add root to dockerfile dev * feat: add DescriptionBox component * feat: adjust description box styling * fix: update carbon version * fix: test link in notification box * fix: remove !import for grid and refactor related code * feat: add padding to page bottom * fix: change where padding bottom is added * feat: add btn text and icon customization feat to submit modal * fix: update snapshot * fix: add end of file lines * fix: fix collection start date col size * fix: update em to rem * fix: add breakpoints to col * fix: update to rem
DerekRoberts
pushed a commit
that referenced
this pull request
May 14, 2024
* fix: add prevent duplicate logic to orcahrd step * fix: remove prevent duplicate orchard id logic * fix: modularize things * fix: add root to dockerfile dev * feat: add DescriptionBox component * feat: adjust description box styling * fix: update carbon version * fix: test link in notification box * fix: remove !import for grid and refactor related code * feat: add padding to page bottom * fix: change where padding bottom is added * feat: add btn text and icon customization feat to submit modal * fix: update snapshot * fix: add end of file lines * fix: fix collection start date col size * fix: update em to rem * fix: add breakpoints to col * fix: update to rem
DerekRoberts
pushed a commit
that referenced
this pull request
May 14, 2024
* fix: add prevent duplicate logic to orcahrd step * fix: remove prevent duplicate orchard id logic * fix: modularize things * fix: add root to dockerfile dev * feat: add DescriptionBox component * feat: adjust description box styling * fix: update carbon version * fix: test link in notification box * fix: remove !import for grid and refactor related code * feat: add padding to page bottom * fix: change where padding bottom is added * feat: add btn text and icon customization feat to submit modal * fix: update snapshot * fix: add end of file lines * fix: fix collection start date col size * fix: update em to rem * fix: add breakpoints to col * fix: update to rem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the usage of
!importantforGridandFlexGridcomponent. The front end was built to accommodate this!importantoverride in the beginning so a lot of components need to be refactored in another issue.To keep each PR small(fairly small), this one only refactored the Collection Step of the registration flow as an example.
To see the reason for this change please see #172 for detail.
Summary of changes
importantfor grid css in the component override fileCollectionStepandSeedlotRegistrationFormSubmitModalcomponentNote:
Fixes #172
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Local testing
Checklist
Thanks for the PR!
Any successful deployments (not always required) will be available below.
Backend
Frontend
Oracle-API
Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow