Fix/175 frontend grid refactoring #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgaseta
requested review from
craigyu,
RMCampos,
SLDonnelly and
DerekRoberts
as code owners
10 tasks
RMCampos
suggested changes
Jun 9, 2023
DerekRoberts
pushed a commit
that referenced
this pull request
May 13, 2024
* fix: refactor dashboard css * fix: fixed responsive bug at exact 1056px screen width * fix: adding column sizes and other minor fixes to dashboard grids * fix: fixing seedlot dashboard grid * fix: fixing create a class page grid * fix: fixing seedlot details page * fix: adjusting columns sizes on seedlot details page * fix: fixing ownership step grid * fix: fixing interim step grid * fix: fixing grid on orchard step * fix: removing broken media query rule * fix: removing unused scss rule * fix: fixing extract and storage step * fix: adjusting columns on collection step * fix: fixing columns and minor adjustments on interim step * fix: fixing my seedlot page grid * fix: adjusting interim step unit test * fix: removing unused import
DerekRoberts
pushed a commit
that referenced
this pull request
May 14, 2024
* fix: refactor dashboard css * fix: fixed responsive bug at exact 1056px screen width * fix: adding column sizes and other minor fixes to dashboard grids * fix: fixing seedlot dashboard grid * fix: fixing create a class page grid * fix: fixing seedlot details page * fix: adjusting columns sizes on seedlot details page * fix: fixing ownership step grid * fix: fixing interim step grid * fix: fixing grid on orchard step * fix: removing broken media query rule * fix: removing unused scss rule * fix: fixing extract and storage step * fix: adjusting columns on collection step * fix: fixing columns and minor adjustments on interim step * fix: fixing my seedlot page grid * fix: adjusting interim step unit test * fix: removing unused import
DerekRoberts
pushed a commit
that referenced
this pull request
May 14, 2024
* fix: refactor dashboard css * fix: fixed responsive bug at exact 1056px screen width * fix: adding column sizes and other minor fixes to dashboard grids * fix: fixing seedlot dashboard grid * fix: fixing create a class page grid * fix: fixing seedlot details page * fix: adjusting columns sizes on seedlot details page * fix: fixing ownership step grid * fix: fixing interim step grid * fix: fixing grid on orchard step * fix: removing broken media query rule * fix: removing unused scss rule * fix: fixing extract and storage step * fix: adjusting columns on collection step * fix: fixing columns and minor adjustments on interim step * fix: fixing my seedlot page grid * fix: adjusting interim step unit test * fix: removing unused import
DerekRoberts
pushed a commit
that referenced
this pull request
May 14, 2024
* fix: refactor dashboard css * fix: fixed responsive bug at exact 1056px screen width * fix: adding column sizes and other minor fixes to dashboard grids * fix: fixing seedlot dashboard grid * fix: fixing create a class page grid * fix: fixing seedlot details page * fix: adjusting columns sizes on seedlot details page * fix: fixing ownership step grid * fix: fixing interim step grid * fix: fixing grid on orchard step * fix: removing broken media query rule * fix: removing unused scss rule * fix: fixing extract and storage step * fix: adjusting columns on collection step * fix: fixing columns and minor adjustments on interim step * fix: fixing my seedlot page grid * fix: adjusting interim step unit test * fix: removing unused import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed grid for all existing pages on SPAR.
Added some negative margins, which can be considered a bad practice, but since it is used only to bring elements closer together, I figured it is okay. Please shout out if you disagree and we can discuss other implementations. This practice is being used by Carbon too.
Fixes #175
Type of change
How Has This Been Tested?
Manually tested and ran unit tests.
Checklist
Thanks for the PR!
Any successful deployments (not always required) will be available below.
Backend
Frontend
Oracle-API
Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow