Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update node.js to v20 #274

Closed
wants to merge 5 commits into from
Closed

Conversation

bcgov-devops
Copy link
Contributor

@bcgov-devops bcgov-devops commented Jun 25, 2023

This PR contains the following updates:

Package Type Update Change
node final major 18.16.1-alpine3.17 -> 20.3.1-alpine3.17
node stage major 18.16.1-alpine3.17 -> 20.3.1-alpine3.17

Release Notes

nodejs/node

v20.3.1: 2023-06-20, Version 20.3.1 (Current), @​RafaelGSS

Compare Source

This is a security release.

Notable Changes

The following CVEs are fixed in this release:

More detailed information on each of the vulnerabilities can be found in June 2023 Security Releases blog post.

Commits

v20.3.0: 2023-06-08, Version 20.3.0 (Current), @​targos

Compare Source

Notable Changes
Commits

v20.2.0: 2023-05-16, Version 20.2.0 (Current), @​targos

Compare Source

Notable Changes
  • [c092df9094] - doc: add ovflowd to collaborators (Claudio Wunder) #​47844
  • [4197a9a5a0] - (SEMVER-MINOR) http: prevent writing to the body when not allowed by HTTP spec (Gerrard Lindsay) #​47732
  • [c4596b9ce7] - (SEMVER-MINOR) sea: add option to disable the experimental SEA warning (Darshan Sen) #​47588
  • [17befe008c] - (SEMVER-MINOR) test_runner: add skip, todo, and only shorthands to test (Chemi Atlow) #​47909
  • [a0634d7f89] - (SEMVER-MINOR) url: add value argument to URLSearchParams has and delete methods (Sankalp Shubham) #​47885
Commits

v20.1.0: 2023-05-03, Version 20.1.0 (Current), @​targos

Compare Source

Notable Changes

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@DerekRoberts
Copy link
Member

@craigyu @RMCampos This is a big enough update we should probably write an issue. That said, it appears to be fine. Opinions?

@craigyu
Copy link
Collaborator

craigyu commented Jun 26, 2023

@craigyu @RMCampos This is a big enough update we should probably write an issue. That said, it appears to be fine. Opinions?

@DerekRoberts This will require us update other packages such as @types/node, any reason why we are moving away from LTS?

@DerekRoberts
Copy link
Member

@craigyu @RMCampos This is a big enough update we should probably write an issue. That said, it appears to be fine. Opinions?

@DerekRoberts This will require us update other packages such as @types/node, any reason why we are moving away from LTS?

@craigyu v20 becomes the new LTS in October. It's a good idea to upgrade early.

@craigyu
Copy link
Collaborator

craigyu commented Jun 26, 2023

@DerekRoberts do you prefer another PR to update @types/node or should I push a commit to this one?

@DerekRoberts
Copy link
Member

@DerekRoberts do you prefer another PR to update @types/node or should I push a commit to this one?

IMO it's easier to see everything in one PR, but this is your call.

@bcgov-devops
Copy link
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@craigyu
Copy link
Collaborator

craigyu commented Jun 28, 2023

@DerekRoberts do you prefer another PR to update @types/node or should I push a commit to this one?

IMO it's easier to see everything in one PR, but this is your call.

I will do that

@craigyu craigyu linked an issue Jun 28, 2023 that may be closed by this pull request
Copy link
Collaborator

@craigyu craigyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOed 20

@DerekRoberts
Copy link
Member

Good catch @craigyu! Let's close this and worry later. :)

@DerekRoberts DerekRoberts deleted the renovate/node-20.x branch June 29, 2023 02:46
@bcgov-devops
Copy link
Contributor Author

bcgov-devops commented Jun 29, 2023

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 20.x releases. But if you manually upgrade to 20.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review dependencies update PR
4 participants