Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/favourite-activity-test-created #544

Merged
merged 16 commits into from
Oct 23, 2023
Merged

feat/favourite-activity-test-created #544

merged 16 commits into from
Oct 23, 2023

Conversation

ArthurEncr
Copy link
Contributor

@ArthurEncr ArthurEncr commented Oct 6, 2023 •
edited by github-actions bot
Loading

Description

Favorites activity test added to dashboard page tests

  • Favorite each page (Seedlots, Create A class and My seedlots) and check if the shortcut is working
  • Test highlight and delete the cards
  • Test if the empty section is showing

Fixes #528

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How to test?

  • Export all environment variables (on terminal: export CYPRESS_USERNAME=[USERNAME] and same for password)
  • Run the login file test with: yarn cy:run --spec cypress/e2e/smoke-test/[TEST FILE] or npm run cy:open and select the test

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend
Frontend
Oracle-API

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@ArthurEncr ArthurEncr requested a review from craigyu as a code owner October 6, 2023 19:25
@ArthurEncr ArthurEncr linked an issue Oct 6, 2023 that may be closed by this pull request
Add Fav Activity Tests to Dashboard #528
Closed
mgaseta
mgaseta requested changes Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@mgaseta mgaseta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Screenshot from 2023-08-31 12-02-48

Added only some minor markups and started some discussions.

frontend/cypress/e2e/smoke-test/dashboard-page.cy.ts Outdated Show resolved Hide resolved
frontend/cypress/e2e/smoke-test/dashboard-page.cy.ts Outdated Show resolved Hide resolved
frontend/cypress/e2e/smoke-test/dashboard-page.cy.ts Outdated Show resolved Hide resolved
frontend/cypress/e2e/smoke-test/dashboard-page.cy.ts Outdated Show resolved Hide resolved
frontend/cypress/e2e/smoke-test/dashboard-page.cy.ts Outdated Show resolved Hide resolved
frontend/cypress/e2e/smoke-test/dashboard-page.cy.ts Outdated Show resolved Hide resolved
frontend/cypress/e2e/smoke-test/dashboard-page.cy.ts Outdated Show resolved Hide resolved
@ArthurEncr ArthurEncr requested a review from mgaseta October 12, 2023 17:21
@craigyu
Copy link
Collaborator

craigyu commented Oct 12, 2023

image
Your tests still use cy.wait(), please read the description that I tagged you in #532

@craigyu craigyu closed this Oct 12, 2023
@craigyu
Copy link
Collaborator

craigyu commented Oct 12, 2023 •
edited
Loading

Please do not bundle tests together.
Each "add a fav activity"+ "verify the card" is showing should be inside its own it(), instead of all three bundled together. Same thing for deleting.
It's a good practice to write tests with isolation in mind:
https://docs.cypress.io/guides/core-concepts/test-isolation

@craigyu
Copy link
Collaborator

craigyu commented Oct 12, 2023

clicked the wrong button that closed the PR

@craigyu craigyu reopened this Oct 12, 2023
craigyu
craigyu requested changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@craigyu craigyu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test is failing.
https://github.com/bcgov/nr-spar/actions/runs/6498873208/job/17651328792#step:3:129

@ArthurEncr ArthurEncr requested a review from craigyu October 16, 2023 13:28
mgaseta
mgaseta approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@mgaseta mgaseta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🥇 💯 🧪

@ArthurEncr ArthurEncr requested a review from craigyu October 19, 2023 12:18
@ArthurEncr ArthurEncr requested a review from craigyu October 20, 2023 14:14
craigyu
craigyu approved these changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@craigyu craigyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job Arthur!

@craigyu craigyu merged commit 178b2fd into main Oct 23, 2023
19 checks passed
@craigyu craigyu deleted the feat/528-fav-activity-tests branch October 23, 2023 16:38
@ArthurEncr ArthurEncr linked an issue Oct 30, 2023 that may be closed by this pull request
Edit cypress test description #561
Closed
DerekRoberts pushed a commit that referenced this pull request May 13, 2024
@ArthurEncr @DerekRoberts
feat/favourite-activity-test-created (#544)
e903c17 
* feat/favourite-activity-test-created

* fix: fixing typo

* feat: dashboard test divided into small parts

* feat: class prefix created

* fix: tests divided into smaller parts

* fix: removing delays

* fix: changing way to select delect and hightlight button

* fix: check if card is gone after delete

* fix: fixing name of test
DerekRoberts pushed a commit that referenced this pull request May 14, 2024
@ArthurEncr @DerekRoberts
feat/favourite-activity-test-created (#544)
c14daff 
* feat/favourite-activity-test-created

* fix: fixing typo

* feat: dashboard test divided into small parts

* feat: class prefix created

* fix: tests divided into smaller parts

* fix: removing delays

* fix: changing way to select delect and hightlight button

* fix: check if card is gone after delete

* fix: fixing name of test
DerekRoberts pushed a commit that referenced this pull request May 14, 2024
@ArthurEncr @DerekRoberts
feat/favourite-activity-test-created (#544)
be8a923 
* feat/favourite-activity-test-created

* fix: fixing typo

* feat: dashboard test divided into small parts

* feat: class prefix created

* fix: tests divided into smaller parts

* fix: removing delays

* fix: changing way to select delect and hightlight button

* fix: check if card is gone after delete

* fix: fixing name of test
DerekRoberts pushed a commit that referenced this pull request May 14, 2024
@ArthurEncr @DerekRoberts
feat/favourite-activity-test-created (#544)
3a80136 
* feat/favourite-activity-test-created

* fix: fixing typo

* feat: dashboard test divided into small parts

* feat: class prefix created

* fix: tests divided into smaller parts

* fix: removing delays

* fix: changing way to select delect and hightlight button

* fix: check if card is gone after delete

* fix: fixing name of test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgaseta mgaseta mgaseta approved these changes

@craigyu craigyu craigyu approved these changes

@RMCampos RMCampos Awaiting requested review from RMCampos

@DerekRoberts DerekRoberts Awaiting requested review from DerekRoberts DerekRoberts is a code owner

@SLDonnelly SLDonnelly Awaiting requested review from SLDonnelly SLDonnelly is a code owner

Assignees

@ArthurEncr ArthurEncr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Edit cypress test description Add Fav Activity Tests to Dashboard
3 participants
@ArthurEncr @craigyu @mgaseta