Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: seedlot columns and area of use #685

Merged
merged 6 commits into from
Dec 1, 2023
Merged

Conversation

RMCampos
Copy link
Contributor

@RMCampos RMCampos commented Nov 27, 2023

Description

Closes no issue

Changelog

New

  • 2 SQL migrations: V21 and V22;
  • Seedlot Seed Plan Zone entity class;

Changed

  • Seedlot entity class

Removed

  • Seedlot columns tested_parent_tree_cont_pct and coancestry;

How was this tested?

  • 🧠 Not needed
  • 👀 Eyeball
  • 🤖 Added tests

What gif/image best describes this PR or how it makes you feel?


Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend
Frontend
Oracle-API

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

Ricardo Campos added 2 commits November 27, 2023 15:58
Copy link
Member

@DerekRoberts DerekRoberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, small change. :)

Copy link
Collaborator

@craigyu craigyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Checkstyle reported 1 error

Copy link
Collaborator

@mgaseta mgaseta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Added only a couple of non-blocking questions.

@RMCampos
Copy link
Contributor Author

RMCampos commented Dec 1, 2023

68747470733a2f2f6d65646961332e67697068792e636f6d2f6d656469612f49654b6743446c7054715251625a456842462f67697068792e676966

LGTM
Checkstyle reported 1 error

Fixed here 088501d

@RMCampos RMCampos merged commit abfc418 into main Dec 1, 2023
18 checks passed
@RMCampos RMCampos deleted the fix/seedlot-columns-and-more branch December 1, 2023 17:54
DerekRoberts pushed a commit that referenced this pull request May 13, 2024
* fix: seedlot columns and area of use

no issue related

* feat: add area of use entity class

no issue related

* chore: rename wrong seedlot variable name

* chore: replace tabs by space on migration v22

* chore: add missing javadoc for the SeedlotSeedPlanZoneEntity class
DerekRoberts pushed a commit that referenced this pull request May 14, 2024
* fix: seedlot columns and area of use

no issue related

* feat: add area of use entity class

no issue related

* chore: rename wrong seedlot variable name

* chore: replace tabs by space on migration v22

* chore: add missing javadoc for the SeedlotSeedPlanZoneEntity class
DerekRoberts pushed a commit that referenced this pull request May 14, 2024
* fix: seedlot columns and area of use

no issue related

* feat: add area of use entity class

no issue related

* chore: rename wrong seedlot variable name

* chore: replace tabs by space on migration v22

* chore: add missing javadoc for the SeedlotSeedPlanZoneEntity class
DerekRoberts pushed a commit that referenced this pull request May 14, 2024
* fix: seedlot columns and area of use

no issue related

* feat: add area of use entity class

no issue related

* chore: rename wrong seedlot variable name

* chore: replace tabs by space on migration v22

* chore: add missing javadoc for the SeedlotSeedPlanZoneEntity class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants