Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/596 implement edit applicant info screen #691

Merged
merged 18 commits into from
Dec 4, 2023
Merged

Feat/596 implement edit applicant info screen #691

merged 18 commits into from
Dec 4, 2023

Conversation

craigyu
Copy link
Collaborator

@craigyu craigyu commented Nov 29, 2023 •
edited by github-actions bot
Loading

Description

Closes #596 #618

Changelog

New

  • Added new types to reduce visual clutter such as FormInputType & { value: MultiOptionsObj }
    • image
  • Added a utils file src/utils/FormInputUtils.ts that generate the objects above:
    • e.g.
    •   export const getBooleanInputObj = (id: string, value: boolean): BooleanInputType => ({
    id,
    isInvalid,
    value
  });
  • Added a component LotApplicantAndInfoForm
    • This component displays a form for seedlot or veglot creation/edition.
    • it manipulates the form data in the parent component only, and the parent component submit this form data

Changed

  • Changed the way how default agency and location code are set in SeedlotRegistrationForm
  • Modified logic in ApplicantAgencyFields, the component now directly updates the parent component's state rather than maintaining a copy in its own state. Some prop names might have changed after resolving conflicts.
  • In Cypress, moved intercept functions to cypress/support/e2e.ts so the intercepts are global

Removed

  • bunch of useless validation concept code from before

How was this tested?

  • 🧠 Not needed
  • 👀 Eyeball
  • 🤖 Added tests

What gif/image best describes this PR or how it makes you feel?

Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend
Frontend
Oracle-API

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend
Frontend
Oracle-API

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend
Frontend
Oracle-API

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@craigyu craigyu added the front-end front-end related task label Nov 29, 2023
@craigyu craigyu self-assigned this Nov 29, 2023
This was linked to issues Nov 29, 2023
Implement Edit Applicant Info Screen #596
Closed
Create Seedlot Screen Update #618
Closed
RMCampos
RMCampos approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@RMCampos RMCampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice refactoring with the form input type thing 🤯

frontend/src/components/LotApplicantAndInfoForm/SeedlotInformation.tsx Show resolved Hide resolved
mgaseta
mgaseta requested changes Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@mgaseta mgaseta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!
Added a few markups and questions only.

frontend/src/components/ApplicantAgencyFields/index.tsx Outdated Show resolved Hide resolved
frontend/src/components/LotApplicantAndInfoForm/SeedlotInformation.tsx Show resolved Hide resolved
frontend/src/components/LotApplicantAndInfoForm/index.tsx Show resolved Hide resolved
frontend/src/types/FormInputType.ts Show resolved Hide resolved
frontend/src/views/Seedlot/CreateAClass/index.tsx Outdated Show resolved Hide resolved
frontend/src/views/Seedlot/EditAClassApplication/index.tsx Show resolved Hide resolved
frontend/src/views/Seedlot/SeedlotRegistrationForm/index.tsx Show resolved Hide resolved
@craigyu craigyu requested a review from mgaseta December 4, 2023 18:17
mgaseta
mgaseta approved these changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@mgaseta mgaseta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 💯 🥇
(I'll not leave an Office gif this time...)

@craigyu craigyu merged commit 613adc7 into main Dec 4, 2023
16 of 17 checks passed
@craigyu craigyu deleted the feat/596-implement-edit-applicant-info-screen branch December 4, 2023 23:03
DerekRoberts pushed a commit that referenced this pull request May 13, 2024
@craigyu @DerekRoberts
Feat/596 implement edit applicant info screen (#691)
1768bc1 
* feat: stashing changes

* bug: stuck on useEffect loop

* fix: useEffect loop, TODO: add checkbox field back

* feat: refactor agency fields

* feat: refactor complete, TODO: integrate endpoint

* feat: endpoint integration complete

* fix: update isInvalid value

* fix: resolve conflict

* fix: form review

* fix: cypress

* fix: remove commented out codes

* fix: rearranging imports to make mg happy

* fix: onblur conditions

* fix: typo and style
DerekRoberts pushed a commit that referenced this pull request May 14, 2024
@craigyu @DerekRoberts
Feat/596 implement edit applicant info screen (#691)
6904172 
* feat: stashing changes

* bug: stuck on useEffect loop

* fix: useEffect loop, TODO: add checkbox field back

* feat: refactor agency fields

* feat: refactor complete, TODO: integrate endpoint

* feat: endpoint integration complete

* fix: update isInvalid value

* fix: resolve conflict

* fix: form review

* fix: cypress

* fix: remove commented out codes

* fix: rearranging imports to make mg happy

* fix: onblur conditions

* fix: typo and style
DerekRoberts pushed a commit that referenced this pull request May 14, 2024
@craigyu @DerekRoberts
Feat/596 implement edit applicant info screen (#691)
c16e098 
* feat: stashing changes

* bug: stuck on useEffect loop

* fix: useEffect loop, TODO: add checkbox field back

* feat: refactor agency fields

* feat: refactor complete, TODO: integrate endpoint

* feat: endpoint integration complete

* fix: update isInvalid value

* fix: resolve conflict

* fix: form review

* fix: cypress

* fix: remove commented out codes

* fix: rearranging imports to make mg happy

* fix: onblur conditions

* fix: typo and style
DerekRoberts pushed a commit that referenced this pull request May 14, 2024
@craigyu @DerekRoberts
Feat/596 implement edit applicant info screen (#691)
c4663ae 
* feat: stashing changes

* bug: stuck on useEffect loop

* fix: useEffect loop, TODO: add checkbox field back

* feat: refactor agency fields

* feat: refactor complete, TODO: integrate endpoint

* feat: endpoint integration complete

* fix: update isInvalid value

* fix: resolve conflict

* fix: form review

* fix: cypress

* fix: remove commented out codes

* fix: rearranging imports to make mg happy

* fix: onblur conditions

* fix: typo and style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgaseta mgaseta mgaseta approved these changes

@RMCampos RMCampos RMCampos approved these changes

@DerekRoberts DerekRoberts Awaiting requested review from DerekRoberts DerekRoberts is a code owner

@SLDonnelly SLDonnelly Awaiting requested review from SLDonnelly SLDonnelly is a code owner

Assignees

@craigyu craigyu

Labels
front-end front-end related task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Seedlot Screen Update Implement Edit Applicant Info Screen
3 participants
@craigyu @RMCampos @mgaseta