Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using manual secrets, plus secret and variable cleanup #74

Merged
merged 11 commits into from
May 9, 2023

Conversation

DerekRoberts
Copy link
Member

@DerekRoberts DerekRoberts commented May 8, 2023

Fix vars/secrets that have been loaded with manual secrets.


Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend
Frontend
Oracle-API

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@DerekRoberts DerekRoberts self-assigned this May 8, 2023
@DerekRoberts DerekRoberts added the bug Something isn't working label May 8, 2023
@DerekRoberts DerekRoberts reopened this May 8, 2023
@DerekRoberts DerekRoberts linked an issue May 8, 2023 that may be closed by this pull request
@DerekRoberts DerekRoberts changed the title Bug/backend vars Stop using manual secrets, plus secret and variable cleanup May 8, 2023
@DerekRoberts DerekRoberts marked this pull request as ready for review May 8, 2023 21:37
@DerekRoberts DerekRoberts marked this pull request as draft May 8, 2023 21:38
@DerekRoberts DerekRoberts marked this pull request as ready for review May 8, 2023 21:39
craigyu
craigyu previously approved these changes May 8, 2023
Copy link
Collaborator

@craigyu craigyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lovely

@DerekRoberts DerekRoberts merged commit 5e694cd into main May 9, 2023
@DerekRoberts DerekRoberts deleted the bug/backendVars branch May 9, 2023 00:10
@DerekRoberts DerekRoberts linked an issue May 12, 2023 that may be closed by this pull request
DerekRoberts added a commit that referenced this pull request May 13, 2024
* Add ALLOWED_ORIGINS to code base

* Add FORESTCLIENTAPI_ADDRESS

* Add KEYCLOAK_REALM_URL

* Add FORESTCLIENTAPI_ADDRESS

* Extra backend label

* Add FORESTCLIENTAPI_KEY

* Create secret for backend

* Update SERVICE_NAME
DerekRoberts added a commit that referenced this pull request May 14, 2024
* Add ALLOWED_ORIGINS to code base

* Add FORESTCLIENTAPI_ADDRESS

* Add KEYCLOAK_REALM_URL

* Add FORESTCLIENTAPI_ADDRESS

* Extra backend label

* Add FORESTCLIENTAPI_KEY

* Create secret for backend

* Update SERVICE_NAME
DerekRoberts added a commit that referenced this pull request May 14, 2024
* Add ALLOWED_ORIGINS to code base

* Add FORESTCLIENTAPI_ADDRESS

* Add KEYCLOAK_REALM_URL

* Add FORESTCLIENTAPI_ADDRESS

* Extra backend label

* Add FORESTCLIENTAPI_KEY

* Create secret for backend

* Update SERVICE_NAME
DerekRoberts added a commit that referenced this pull request May 14, 2024
* Add ALLOWED_ORIGINS to code base

* Add FORESTCLIENTAPI_ADDRESS

* Add KEYCLOAK_REALM_URL

* Add FORESTCLIENTAPI_ADDRESS

* Extra backend label

* Add FORESTCLIENTAPI_KEY

* Create secret for backend

* Update SERVICE_NAME
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Backend KEYCLOAK_REALM_URL not in code base
2 participants