Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

styling changes to timeline #163

Merged
merged 1 commit into from
May 27, 2022

Conversation

wadeking98
Copy link
Contributor

Resolves: #152
Added styling to timeline
Fixed word wrap
Changed "Show Expired" wording

Signed-off-by: wadeking98 <wkingnumber2@gmail.com>
amanji
amanji previously approved these changes May 27, 2022
@wadeking98 wadeking98 merged commit 4924a0a into bcgov:main May 27, 2022
@swcurran
Copy link
Contributor

Happy to see this promoted -- good stuff! I do have a couple of other changes that are needed, probably requiring a new PR. Please open a new issue or two to address these -- or let me know if I should. Add comments below on this PR if you want.

  • The (i) popup on "Show Inactive Credentials" is about "expired credentials". The text needs to be updated. This is a must have.
    • Current Text: Expired credential: An expired credential is one that has an expiry date before the current date, or has been revoked by the credential issuer.
    • Suggestion: Inactive Credentials: Inactive credentials are ones that were issued at some point and then later replaced by an updated credential of the same type. The dates during which the credential was active are displayed and there is a relationship to the currently active credential. Note that an active credential may have multiple related inactive credentials. For example, an organization that has had several name changes would have multiple registration credentials for the periods it operated under each name.
  • I think we should change the date range presentation on the timeline to be more explicit, so it is very clear it is a range:
    • From: <date> to <date | Present>[: <reason>]
    • Examples from below:
      • From Mar 16, 2011 to Present
      • From Mar 16, 2011 to Dec 02, 2011: Credential replaced

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ideas for discussion - Credential / Organization Status
3 participants