Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit note updates from review. #1582

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Unit note updates from review. #1582

merged 1 commit into from
Oct 13, 2023

Conversation

doug-lovett
Copy link
Collaborator

Issue #: /bcgov/entity###

Description of changes:
Issue #: /bcgov/entity#18138

  • update fee for NCON, NPUB, REST unit note registration types.

Issue #: /bcgov/entity#18146

  • search report unit notes missing trailing separator line.

Issue #: /bcgov/entity#18140

  • remove phone number from search report unit note person giving notice.

Issue #: /bcgov/entity#18150

  • NCAN unit note registration report title include cancelled note.

Issue #: /bcgov/entity#18145

  • Search report exclude NCAN from unit notes.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

Signed-off-by: Doug Lovett <doug@diamante.ca>
Copy link
Collaborator

@dimak1 dimak1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work to fix many tickets!

Copy link
Contributor

@RuoxuanPengBC RuoxuanPengBC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Collaborator

@cameron-eyds cameron-eyds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, sorry i missed this PR!

@doug-lovett doug-lovett merged commit 7e785c8 into bcgov:main Oct 13, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants