Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transport Permit form #1689

Merged
merged 9 commits into from
Jan 20, 2024
Merged

Transport Permit form #1689

merged 9 commits into from
Jan 20, 2024

Conversation

dimak1
Copy link
Collaborator

@dimak1 dimak1 commented Jan 12, 2024

Issue #:

Description of changes:

  • Transport Permit Form components for Staff only (QS is coming in next PR)
  • Refactor few components to make them reusable for this flow
  • Refactor Land or Lease component
  • Styling updates/fixes
  • Unit tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

@dimak1 dimak1 added the MHR Transport Permit Transport Permit Registration label Jan 12, 2024
@dimak1 dimak1 self-assigned this Jan 12, 2024
@dimak1 dimak1 changed the title Transport Permit form (Staff Only) Transport Permit form (Part 1 - Staff Only) Jan 12, 2024
@dimak1
Copy link
Collaborator Author

dimak1 commented Jan 12, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1689-ef68dsqp.web.app

Copy link
Collaborator

@doug-lovett doug-lovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Collaborator

@cameron-eyds cameron-eyds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dimak1
Copy link
Collaborator Author

dimak1 commented Jan 13, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1689-ef68dsqp.web.app

@dimak1 dimak1 changed the title Transport Permit form (Part 1 - Staff Only) Transport Permit form Jan 15, 2024
@dimak1
Copy link
Collaborator Author

dimak1 commented Jan 15, 2024

@cameron-eyds I added a Tax Certificate component, if you want to take another look.

@cameron-eyds
Copy link
Collaborator

@cameron-eyds I added a Tax Certificate component, if you want to take another look.

@dimak1 Looks great!

Copy link
Collaborator

@doug-lovett doug-lovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great.

@dimak1 dimak1 force-pushed the feat/transport-permit-form branch from ef1f759 to 655dafa Compare January 17, 2024 04:04
@dimak1
Copy link
Collaborator Author

dimak1 commented Jan 17, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1689-ef68dsqp.web.app

@dimak1
Copy link
Collaborator Author

dimak1 commented Jan 17, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1689-ef68dsqp.web.app

@dimak1
Copy link
Collaborator Author

dimak1 commented Jan 20, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1689-ef68dsqp.web.app

@dimak1 dimak1 force-pushed the feat/transport-permit-form branch from 690ecca to 609f098 Compare January 20, 2024 01:59
@dimak1 dimak1 merged commit 64bddb7 into bcgov:main Jan 20, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MHR Transport Permit Transport Permit Registration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants