-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transport Permit Review & Submit #1713
Conversation
/gcbrun |
ppr-ui/src/components/mhrRegistration/ReviewConfirm/HomeLocationReview.vue
Show resolved
Hide resolved
Temporary Url for review: https://bcregistry-assets-dev--pr-1713-smgchdfh.web.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
/gcbrun |
Temporary Url for review: https://bcregistry-assets-dev--pr-1713-smgchdfh.web.app |
487be1a
to
cb73e37
Compare
/gcbrun |
Temporary Url for review: https://bcregistry-assets-dev--pr-1713-smgchdfh.web.app |
/gcbrun |
Temporary Url for review: https://bcregistry-assets-dev--pr-1713-smgchdfh.web.app |
/gcbrun |
Temporary Url for review: https://bcregistry-assets-dev--pr-1713-smgchdfh.web.app |
/gcbrun |
Temporary Url for review: https://bcregistry-assets-dev--pr-1713-smgchdfh.web.app |
/gcbrun |
Temporary Url for review: https://bcregistry-assets-dev--pr-1713-smgchdfh.web.app |
@setStoreProperty="setMhrTransferSubmittingParty" | ||
@setStoreProperty="isChangeLocationActive | ||
? setMhrTransportPermit({ key: 'submittingParty', value: $event }) | ||
: setMhrTransferSubmittingParty" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dimak1 maybe here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned in chat, $event may need to pass explicitly because of the ternary?
The getter i commented on above is probably fine, since it populates the component
Issue #:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).