Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transport Permit Review & Submit #1713

Merged
merged 15 commits into from
Feb 2, 2024

Conversation

dimak1
Copy link
Collaborator

@dimak1 dimak1 commented Jan 31, 2024

Issue #:

Description of changes:

  • Review and Confirm page updates
  • Submission of Transport Permit
  • Refactor existing components
  • Unit tests pending in upcoming commit

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

@dimak1 dimak1 added the MHR Transport Permit Transport Permit Registration label Jan 31, 2024
@dimak1 dimak1 self-assigned this Jan 31, 2024
@dimak1
Copy link
Collaborator Author

dimak1 commented Jan 31, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1713-smgchdfh.web.app

Copy link
Collaborator

@cameron-eyds cameron-eyds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few comments.

Copy link
Collaborator

@doug-lovett doug-lovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@dimak1
Copy link
Collaborator Author

dimak1 commented Jan 31, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1713-smgchdfh.web.app

@dimak1 dimak1 force-pushed the feat/transport-permit-review branch from 487be1a to cb73e37 Compare January 31, 2024 23:24
@dimak1
Copy link
Collaborator Author

dimak1 commented Jan 31, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1713-smgchdfh.web.app

@dimak1
Copy link
Collaborator Author

dimak1 commented Feb 1, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1713-smgchdfh.web.app

@dimak1
Copy link
Collaborator Author

dimak1 commented Feb 1, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1713-smgchdfh.web.app

@dimak1
Copy link
Collaborator Author

dimak1 commented Feb 2, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1713-smgchdfh.web.app

@dimak1
Copy link
Collaborator Author

dimak1 commented Feb 2, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1713-smgchdfh.web.app

@dimak1 dimak1 merged commit 1d59cef into bcgov:main Feb 2, 2024
5 checks passed
@setStoreProperty="setMhrTransferSubmittingParty"
@setStoreProperty="isChangeLocationActive
? setMhrTransportPermit({ key: 'submittingParty', value: $event })
: setMhrTransferSubmittingParty"
Copy link
Collaborator

@cameron-eyds cameron-eyds Feb 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dimak1 maybe here

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in chat, $event may need to pass explicitly because of the ternary?
The getter i commented on above is probably fine, since it populates the component

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MHR Transport Permit Transport Permit Registration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants