Bug fix for Citizen Left Snowplow call #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Set versions for kombu in requirements.txt for Snowplow to work
- additional arg snowplow_event added for multiple actions single endpoint
Translate new to current (old) channel names.
Deleted mysqlclient version requirement, only required locally
# Conflicts: # api/app/resources/citizen/citizen_finish_service.py # api/app/resources/citizen/citizen_list.py
- delete old socketio call
- keep Snowplow call, delete old socketio call, keep new one.
- Added extra parameters required for finish and hold - fixed mistake in channel conversion (old to new) code - changed IDs to codes in chooseservice - breaks existing chooseservice, until new Snowplow schema added
- Pass citizen ID in to Snowplow call, don't get from (non-existant) SR
- use SR data if it exists, otherwise use citizen ID passed in
sumesh-aot
pushed a commit
to sumesh-aot/queue-management
that referenced
this pull request
May 5, 2020
Sbcappointments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug introduced by my Snowplow call, citizen left, no service request.