Updated DockerFile and node version in devcontainer #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
midhunmanoj2024
requested review from
chrsamp,
josekudiyirippil and
Rajandeep98
as code owners
midhunmanoj2024
force-pushed
the
SBCQ-172
branch
from
ac4b2e2
to
77d4ee6
Compare
chrsamp
requested changes
Aug 8, 2024
There was a problem hiding this comment.
Hey @midhunmanoj2024, I'm running into the following issues when I try to build the devcontainer on local:
- Keycloak isn't part of the devcontainer environment. If I manually add the quay.io/keycloak/keycloak image, the steps in the README don't match (local wants a realm called "registry" and there are no instructions to configure a custom realm). There is a Dockerfile for Keycloak in the
keycloak-local-testserverdirectory that doesn't build because of issues withyum. postCreateCommand.shdoesn't exit cleanly because the$(npm bin)/cypress installcommand on line 111 errors out. I'm also not 100% sure why we run npm-force-resolutions as a preinstall command, but I've also had the script timeout during that command as well.
chrsamp
approved these changes
Aug 13, 2024
midhunmanoj2024
force-pushed
the
SBCQ-172
branch
from
b9ee451
to
6961362
Compare
josekudiyirippil
had a problem deploying
to
The Q Dev
GitHub Actions
Failure
josekudiyirippil
had a problem deploying
to
The Q Dev
GitHub Actions
Failure
midhunmanoj2024
force-pushed
the
SBCQ-172
branch
from
656ee38
to
25ad6bf
Compare
midhunmanoj2024
had a problem deploying
to
The Q Dev
GitHub Actions
Failure
|
josekudiyirippil
had a problem deploying
to
The Q Dev
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.