Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: main merge workflow dispatch and error handling #1649

Merged
merged 3 commits into from
Nov 21, 2023
Merged

feat: main merge workflow dispatch and error handling #1649

merged 3 commits into from
Nov 21, 2023

Conversation

DerekRoberts
Copy link
Member

@DerekRoberts DerekRoberts commented Nov 21, 2023 •
edited
Loading

  • improve scrubbing of last commit for PR number (had been failing on multiline)
  • kick up errors when merging directly to main (which is bad!)
  • workflow_dispatch, currently accepting PR numbers

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@DerekRoberts DerekRoberts self-assigned this Nov 21, 2023
@DerekRoberts DerekRoberts added enhancement New feature or request github_actions Pull requests that update GitHub Actions code labels Nov 21, 2023
@DerekRoberts DerekRoberts linked an issue Nov 21, 2023 that may be closed by this pull request
bug: PR pickup from Main Merge #1648
Closed
@DerekRoberts DerekRoberts marked this pull request as ready for review November 21, 2023 09:28
@DerekRoberts DerekRoberts linked an issue Nov 21, 2023 that may be closed by this pull request
Build emergency/recovery PROD dispatch workflow #1045
Closed
@DerekRoberts DerekRoberts linked an issue Nov 21, 2023 that may be closed by this pull request
Add workflow inputs #1249
Closed
mishraomp
mishraomp approved these changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@mishraomp mishraomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DerekRoberts DerekRoberts changed the title feat: workflow dispatch for main merge workflow feat: main merge workflow dispatch and error handling Nov 21, 2023
@DerekRoberts DerekRoberts merged commit ca21ca9 into main Nov 21, 2023
13 checks passed
@DerekRoberts DerekRoberts deleted the ci/cleanupII branch November 21, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mishraomp mishraomp mishraomp approved these changes

Assignees

@DerekRoberts DerekRoberts

Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code
Projects
DevOps (NR)
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: PR pickup from Main Merge Add workflow inputs Build emergency/recovery PROD dispatch workflow
2 participants
@DerekRoberts @mishraomp