Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding notifications to ping teams of deployment workflow status #1741

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

cberg-aot
Copy link
Collaborator

@cberg-aot cberg-aot commented Dec 29, 2023

Description

Supporting MS Teams Notifications via workflow_run events!!

  • Triggers based on workflow status

Fixes # (issue)

Alerts at the Job/Step level in a workflow arn't really what was wanted.
Alerts whenever workflows are triggered is useful to devs watching the channels to see pr->merge->deploy status

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Implemented in onroutebc

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

@cberg-aot
Copy link
Collaborator Author

Add vars.MS_TEAMS_WEBHOOK_URI to test

Copy link
Member

@DerekRoberts DerekRoberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I'm definitely stealing this. ;)

@mishraomp
Copy link
Collaborator

Add vars.MS_TEAMS_WEBHOOK_URI to test

Teams webhook URI should be secret not vars IMHO, everything else LGTM

Copy link
Collaborator

@mishraomp mishraomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cberg-aot cberg-aot added this pull request to the merge queue Jan 3, 2024
Merged via the queue into main with commit 2f23ecf Jan 3, 2024
15 checks passed
@cberg-aot cberg-aot deleted the feat/notifications branch January 3, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants