Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(frontend): various updates (BC Sans and look and feel) #1804

Merged
merged 9 commits into from
Feb 12, 2024
Merged

feat(frontend): various updates (BC Sans and look and feel) #1804

merged 9 commits into from
Feb 12, 2024

Conversation

mishraomp
Copy link
Collaborator

@mishraomp mishraomp commented Feb 12, 2024 •
edited by github-actions bot
Loading

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@mishraomp
feat(frontend): various updates (BC Sans and look and feel)
5835cde 
Signed-off-by: OMPRAKASH MISHRA <omprakashmishra3978@gmail.com>
@mishraomp
fix: copy paste error
1228eac 
Signed-off-by: OMPRAKASH MISHRA <omprakashmishra3978@gmail.com>
@mishraomp
fix field names
73a5daf 
Signed-off-by: OMPRAKASH MISHRA <omprakashmishra3978@gmail.com>
@mishraomp
fix field names
2c0461f 
Signed-off-by: OMPRAKASH MISHRA <omprakashmishra3978@gmail.com>
DerekRoberts
DerekRoberts approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member

@DerekRoberts DerekRoberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boo image streams! Otherwise, great. :)

@mishraomp
fix proxy and user data
dbeccc3 
Signed-off-by: OMPRAKASH MISHRA <omprakashmishra3978@gmail.com>
@mishraomp
do fresh install for PR deploys all the time.
ad71047 
Signed-off-by: OMPRAKASH MISHRA <omprakashmishra3978@gmail.com>
@mishraomp
wrap it with quotes
15d60ec 
Signed-off-by: OMPRAKASH MISHRA <omprakashmishra3978@gmail.com>
@mishraomp
try mapping with user object
a38f77a 
Signed-off-by: OMPRAKASH MISHRA <omprakashmishra3978@gmail.com>
@mishraomp
Copy link
Collaborator Author

Boo image streams! Otherwise, great. :)

yeah, streaming from ghcr, causing cold starts, so imagestream is a better choice for OpenShift/

@mishraomp
try mapping without user object
98905b9 
Signed-off-by: OMPRAKASH MISHRA <omprakashmishra3978@gmail.com>
@mishraomp mishraomp marked this pull request as ready for review February 12, 2024 17:18
@mishraomp mishraomp enabled auto-merge (squash) February 12, 2024 17:22
@mishraomp mishraomp closed this Feb 12, 2024
auto-merge was automatically disabled February 12, 2024 17:22

Pull request was closed

@mishraomp mishraomp reopened this Feb 12, 2024
@mishraomp mishraomp merged commit 631c512 into main Feb 12, 2024
27 checks passed
@mishraomp mishraomp deleted the chore/various-updates branch February 12, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DerekRoberts DerekRoberts DerekRoberts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
DevOps (NR)
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mishraomp @DerekRoberts