fix: eslint #2205
Draft
fix: eslint #2205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcellmueller
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Sorry I meant to get to this but got busy deploying to AWS with Om. This looks great! I pulled this and ran npm i in the backend directory and verified eslint is working.
Though looks like the backend build is failing, I think there are some more linting issues to fix.
Also one thing to consider is moving to eslint 9 since 8 is EOL. However it uses this flat config, they have a migration tool I had it setup here: https://github.com/bcgov/nr-rec-resources/blob/main/eslint.config.mjs
DerekRoberts
force-pushed
the
fix/eslint
branch
from
d256c50 to
5103289
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2188.
@marcellmueller does this cover your issue adequately? We're trying to make the components modular, so the linting configs are separate. Unless it's fine to mash them together anyway, then swap in a Java or Python backend. Opinions?