Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove limits #2218

Merged
merged 1 commit into from
Dec 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions charts/app/templates/backend/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,6 @@ spec:
- name: FLYWAY_GROUP
value: "true"
resources:
limits:
cpu: 200m
memory: 200Mi
requests:
cpu: 50m
memory: 75Mi
Expand Down Expand Up @@ -90,9 +87,6 @@ spec:
periodSeconds: 30
timeoutSeconds: 5
resources: # this is optional
limits:
cpu: 150m
memory: 150Mi
requests:
cpu: 50m
memory: 75Mi
Expand Down
3 changes: 0 additions & 3 deletions charts/app/templates/frontend/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,6 @@ spec:
periodSeconds: 30
timeoutSeconds: 5
resources:
limits:
cpu: 100m
memory: 150Mi
requests:
cpu: 30m
memory: 50Mi
Expand Down
6 changes: 0 additions & 6 deletions charts/app/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,6 @@ backend:
- prod/api-2
#-- resources specific to vault initContainer. it is optional and is an object.
resources:
limits:
cpu: 50m
memory: 50Mi
requests:
cpu: 50m
memory: 25Mi
Expand Down Expand Up @@ -157,7 +154,4 @@ bitnamipg:
requests:
cpu: 50m
memory: 150Mi
limits:
cpu: 150m
memory: 250Mi

24 changes: 0 additions & 24 deletions charts/crunchy/templates/PostgresCluster.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,6 @@ spec:
requests:
cpu: {{ .Values.crunchy.pgmonitor.exporter.requests.cpu }}
memory: {{ .Values.crunchy.pgmonitor.exporter.requests.memory }}
limits:
cpu: {{ .Values.crunchy.pgmonitor.exporter.limits.cpu }}
memory: {{ .Values.crunchy.pgmonitor.exporter.limits.memory }}

{{ end }}

Expand All @@ -69,19 +66,13 @@ spec:
requests:
cpu: {{ .Values.crunchy.instances.requests.cpu }}
memory: {{ .Values.crunchy.instances.requests.memory }}
limits:
cpu: {{ .Values.crunchy.instances.limits.cpu }}
memory: {{ .Values.crunchy.instances.limits.memory }}

sidecars:
replicaCertCopy:
resources:
requests:
cpu: {{ .Values.crunchy.instances.replicaCertCopy.requests.cpu }}
memory: {{ .Values.crunchy.instances.replicaCertCopy.requests.memory }}
limits:
cpu: {{ .Values.crunchy.instances.replicaCertCopy.limits.cpu }}
memory: {{ .Values.crunchy.instances.replicaCertCopy.limits.memory }}
dataVolumeClaimSpec:
accessModes:
- "ReadWriteOnce"
Expand Down Expand Up @@ -179,35 +170,23 @@ spec:
requests:
cpu: {{ .Values.crunchy.pgBackRest.repoHost.requests.cpu }}
memory: {{ .Values.crunchy.pgBackRest.repoHost.requests.memory }}
limits:
cpu: {{ .Values.crunchy.pgBackRest.repoHost.limits.cpu }}
memory: {{ .Values.crunchy.pgBackRest.repoHost.limits.memory }}
sidecars:
# this stuff is for the "pgbackrest" container in the "postgres-crunchy-ha" set of pods
pgbackrest:
resources:
requests:
cpu: {{ .Values.crunchy.pgBackRest.sidecars.requests.cpu }}
memory: {{ .Values.crunchy.pgBackRest.sidecars.requests.memory }}
limits:
cpu: {{ .Values.crunchy.pgBackRest.sidecars.limits.cpu }}
memory: {{ .Values.crunchy.pgBackRest.sidecars.limits.memory }}
pgbackrestConfig:
resources:
requests:
cpu: {{ .Values.crunchy.pgBackRest.sidecars.requests.cpu }}
memory: {{ .Values.crunchy.pgBackRest.sidecars.requests.memory }}
limits:
cpu: {{ .Values.crunchy.pgBackRest.sidecars.limits.cpu }}
memory: {{ .Values.crunchy.pgBackRest.sidecars.limits.memory }}
jobs:
resources:
requests:
cpu: {{ .Values.crunchy.pgBackRest.jobs.requests.cpu }}
memory: {{ .Values.crunchy.pgBackRest.jobs.requests.memory }}
limits:
cpu: {{ .Values.crunchy.pgBackRest.jobs.limits.cpu }}
memory: {{ .Values.crunchy.pgBackRest.jobs.limits.memory }}
{{- end }}
patroni:
dynamicConfiguration:
Expand Down Expand Up @@ -240,9 +219,6 @@ spec:
requests:
cpu: {{ .Values.crunchy.proxy.pgBouncer.requests.cpu }}
memory: {{ .Values.crunchy.proxy.pgBouncer.requests.memory }}
limits:
cpu: {{ .Values.crunchy.proxy.pgBouncer.limits.cpu }}
memory: {{ .Values.crunchy.proxy.pgBouncer.limits.memory }}
affinity:
podAntiAffinity:
preferredDuringSchedulingIgnoredDuringExecution:
Expand Down
24 changes: 0 additions & 24 deletions charts/crunchy/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,16 +39,10 @@ crunchy: # enable it for TEST and PROD, for PR based pipelines simply use single
requests:
cpu: 50m
memory: 128Mi
limits:
cpu: 150m
memory: 256Mi
replicaCertCopy:
requests:
cpu: 1m
memory: 32Mi
limits:
cpu: 50m
memory: 64Mi

pgBackRest:
enabled: true
Expand Down Expand Up @@ -81,30 +75,18 @@ crunchy: # enable it for TEST and PROD, for PR based pipelines simply use single
requests:
cpu: 5m
memory: 32Mi
limits:
cpu: 20m
memory: 64Mi
repoHost:
requests:
cpu: 20m
memory: 128Mi
limits:
cpu: 50m
memory: 256Mi
sidecars:
requests:
cpu: 5m
memory: 16Mi
limits:
cpu: 20m
memory: 64Mi
jobs:
requests:
cpu: 20m
memory: 128Mi
limits:
cpu: 100m
memory: 256Mi

patroni:
postgresql:
Expand All @@ -129,9 +111,6 @@ crunchy: # enable it for TEST and PROD, for PR based pipelines simply use single
requests:
cpu: 5m
memory: 32Mi
limits:
cpu: 20m
memory: 64Mi
maxConnections: 10 # make sure less than postgres max connections

# Postgres Cluster resource values:
Expand All @@ -142,6 +121,3 @@ crunchy: # enable it for TEST and PROD, for PR based pipelines simply use single
requests:
cpu: 1m
memory: 16Mi
limits:
cpu: 35m
memory: 32Mi
Loading