feat: email for onboarding and offboarding team mems #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlangy
approved these changes
Dec 20, 2023
app/pages/api/realms/[id].ts
Outdated
| currentRequest.technicalContactEmail !== updateRequest.technicalContactEmail | ||
| ) { | ||
| typeOfContactUpdate = 'Technical Contact'; | ||
| onboardNewRealmAdmin( |
There was a problem hiding this comment.
I had a strange issue earlier where if I wasn't awaiting promises, they would be flaky on whether they actually settled. I think related to this thread: vercel/next.js#14077, if it doesn't complete fast enough it might get skipped. It would be nice to not wait for this to resolve before sending a response but might be necessary
There was a problem hiding this comment.
@jlangy yes agreed, the sendEmail function does return promise so it's good to await for them before delivering the response and in this way we can ensure the emails do get delivered. I have added async awaits for all the email. Can you please take a look tomorrow morning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes SSOTEAM-1205