Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow url override #546

Merged
merged 1 commit into from
Jun 13, 2024
Merged

feat: allow url override #546

merged 1 commit into from
Jun 13, 2024

Conversation

jleach
Copy link
Member

@jleach jleach commented Jun 13, 2024

Allow the external URLs to be overiden rather than relying on ngrok. This will allow devs who cannot use ngrok to user any means they like.

Fixes #543

@jleach
feat: allow url override
08ad18e 
Signed-off-by: Jason C. Leach <jason.leach@fullboar.ca>
@jleach jleach requested a review from esune June 13, 2024 15:59
esune
esune approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@esune esune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jleach 👍🏻

@esune esune merged commit 902c3df into bcgov:main Jun 13, 2024
5 checks passed
@jleach jleach deleted the fix/allow-url-override branch June 13, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esune esune esune approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ngrok blocked on BCNGN
2 participants
@jleach @esune