Configure invitation label for proofs #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucas ONeil <lucasoneil@gmail.com>
Signed-off-by: Lucas ONeil <lucasoneil@gmail.com>
This was referenced Sep 12, 2024
|
Pre-setting candidates for values here bcgov/trust-over-ip-configurations#237 |
WadeBarnes
approved these changes
Sep 12, 2024
esune
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
my_labelin the OOB invitation that we use to contain the proof can be set to control what the BC Wallet displays as the requestor.Set environment and helm config to allow this to be set in an environment. If not provided default is just "VC-AuthN".
We could set this dynamically per-proof, allowing control at the presentation config level, but discussing we're just going to go as an environmental setting for now. Easy to allow overrides in the granular configs at some point if that changes.
Dependency updates also