Add support for existing and new docker compose syntax

[WadeBarnes]

• Dynamically detect the version of docker compose and adjust the calling syntax appropriately.
• resolves undocumented docker compose V2 requirement #170

Signed-off-by: Wade Barnes wade@neoterictech.ca

[WadeBarnes]

@Moopli, here is the fix for the issue you reported. Could you try this out and see if it resolves the issue for you?

[ianco]

When I run ./manage start ... it doesn't seem to start the nodes ...

$ ./manage start --logs
Creating von_webserver_1 ... done
Creating von_node4_1     ... done
Creating von_node2_1     ... done
Creating von_node3_1     ... done
Creating von_node1_1     ... done
Attaching to von_node4_1, von_node2_1, von_node1_1, von_webserver_1, von_node3_1
webserver_1  | Ledger does not exist - Creating genesis data...
webserver_1  | von_generate_transactions
... etc

I get the logs for the webserver but not the nodes. If I open http://localhost:9000 in a browser I get Error initializing pool ledger

[ianco]

The nodes seem to be sleeping:

$ docker ps
CONTAINER ID   IMAGE              COMMAND                  CREATED         STATUS         PORTS                                                           NAMES
69fea24637f5   von-network-base   "/bin/bash -c 'sleep…"   2 minutes ago   Up 2 minutes   0.0.0.0:9707-9708->9707-9708/tcp, :::9707-9708->9707-9708/tcp   von_node4_1
281493fb5759   von-network-base   "/bin/bash -c 'sleep…"   2 minutes ago   Up 2 minutes   0.0.0.0:9703-9704->9703-9704/tcp, :::9703-9704->9703-9704/tcp   von_node2_1
7c8a144b154e   von-network-base   "/bin/bash -c 'sleep…"   2 minutes ago   Up 2 minutes   0.0.0.0:9701-9702->9701-9702/tcp, :::9701-9702->9701-9702/tcp   von_node1_1
1f0e7da389dd   von-network-base   "bash -c 'sleep 10; …"   2 minutes ago   Up 2 minutes   0.0.0.0:9000->8000/tcp, :::9000->8000/tcp                       von_webserver_1
ad98d3dcecbf   von-network-base   "/bin/bash -c 'sleep…"   2 minutes ago   Up 2 minutes   0.0.0.0:9705-9706->9705-9706/tcp, :::9705-9706->9705-9706/tcp   von_node3_1

[Moopli]

It starts cleanly for me, and aries agent test harness tests using the local von pass, thanks!

[WadeBarnes]

@ianco, They shouldn't be sleeping. I didn't change any of the startup commands in the docker-compose file.

[ianco]

Not sure what's going on, I tried deleting & rebuilding the images (cleaned out the docker cache), re-started, and the nodes never seem to start.

[WadeBarnes]

@ianco, What does your docker-compose file look like?

[ianco]

@ianco, What does your docker-compose file look like?

docker-compose.yml.txt

... also:

$ docker-compose --version
docker-compose version 1.29.2, build 5becea4c

[WadeBarnes]

@ianco, you have them sleeping for 4h:

    entrypoint: /bin/bash
    command:
      [
        "-c",
        "sleep 4h"
      ]

It looks like you still have remnants of the configuration from when we were debugging the ledger issues.

[swcurran]

Tested on Docker version 20.10.8, build 3967b7d and all good.

[swcurran]

Nice work!

[ianco]

@ianco, you have them sleeping for 4h:

    entrypoint: /bin/bash
    command:
      [
        "-c",
        "sleep 4h"
      ]

It looks like you still have remnants of the configuration from when we were debugging the ledger issues.

Aha thanks @WadeBarnes good catch, you're right that is a local change, my local von-network is checked out on a branch :-( oops

[swcurran]

I’m having trouble with ./manage down. I thought it was I tried to run it too soon, but it seems consistent:

~/repos/von-network [docker-compose-fixes] 08:13 $ ./manage down

Stopping and removing any running containers ...
Docker version 20.10.8, build 3967b7d
Removing project volumes ...
Error response from daemon: remove von_node1-data: volume is in use - [6d2746ac9d16ce2eee0414b51521e3ee269307e18258f32f31824aa6fd3c0a84]
Error response from daemon: remove von_node2-data: volume is in use - [e78547b9fccae345322091ea5cf76c75d13aca6a00b44405aa1380075aaf856d]
Error response from daemon: remove von_node3-data: volume is in use - [a234e41be056e9f1506894a889b971489f0562863f480c7cf6c319e63bffcdfa]
Error response from daemon: remove von_node4-data: volume is in use - [bdedc51f5b8b882f9467505175ab94b76c601ee0a3d624bd2d94a5c7f0e5d197]
Error response from daemon: remove von_webserver-cli: volume is in use - [4246f4da90a79093c3150d133e68ed27e87cb6a833daec1f8213636453fe4342]
Error response from daemon: remove von_webserver-ledger: volume is in use - [4246f4da90a79093c3150d133e68ed27e87cb6a833daec1f8213636453fe4342]

./manage stop seems fine:

~/repos/von-network [docker-compose-fixes] 08:13 $ ./manage stop
Stopping von_node2_1     ... done
Stopping von_webserver_1 ... done
Stopping von_node1_1     ... done
Stopping von_node3_1     ... done
Stopping von_node4_1     ... done
~/repos/von-network [docker-compose-fixes] 08:14 $ 

[WadeBarnes]

@swcurran, I see a couple things I missed. Another PR is coming shortly, just testing.