Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/v3 pysam upgrade #266

Merged
merged 11 commits into from
Jan 4, 2022
Merged

Feature/v3 pysam upgrade #266

merged 11 commits into from
Jan 4, 2022

Conversation

creisle
Copy link
Member

@creisle creisle commented Dec 29, 2021

Cherry-picks the commits in the other PR onto the develop_v3 branch (#264)

  • new license
  • libcurl add to actions file

BugFixes

  • Use pandas instead of pysam to read vcf files

Breaking Changes

  • drops support for python 3.6 (will add support for 3.9/3.10 in a subsequent pull)

Looks like a lot of the issues with the vcf reading part of pysam in later versions boils down to poor support for SVs in the underlying samtools/bcftools. There are some checks going on that make sense for indels/snps but break for SVs. Unfortunately this applies to all versions of pysam after 0.15.2. This short term solution is a drop-in replacement using pandas so we can bypass those checks.

Note: currently the pandas convert does so row-by-row, we can optimize this to perform these operations in the dataframe itself later if we find the performance lags, I wanted to keep the process as close to the current one as possible for this initial PR

@creisle creisle added this to the v3.0.0 milestone Dec 29, 2021
@creisle creisle self-assigned this Dec 29, 2021
@creisle creisle linked an issue Dec 29, 2021 that may be closed by this pull request
@creisle creisle marked this pull request as draft December 29, 2021 00:13
@creisle creisle closed this Dec 29, 2021
@creisle creisle reopened this Dec 29, 2021
@codecov
Copy link

codecov bot commented Dec 29, 2021

Codecov Report

Merging #266 (9b3c72c) into develop_v3 (dd01854) will increase coverage by 0.03%.
The diff coverage is 97.01%.

Impacted file tree graph

@@              Coverage Diff               @@
##           develop_v3     #266      +/-   ##
==============================================
+ Coverage       86.66%   86.70%   +0.03%     
==============================================
  Files              53       53              
  Lines            8843     8897      +54     
  Branches         2234     2310      +76     
==============================================
+ Hits             7664     7714      +50     
- Misses            719      722       +3     
- Partials          460      461       +1     
Flag Coverage Δ
unittests 86.70% <97.01%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/mavis/tools/vcf.py 95.65% <97.01%> (+0.41%) ⬆️
src/mavis/breakpoint.py 90.61% <0.00%> (-0.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c029b5a...9b3c72c. Read the comment docs.

@creisle creisle marked this pull request as ready for review December 29, 2021 01:38
@creisle creisle requested a review from zhemingfan December 29, 2021 19:31
Copy link
Collaborator

@zhemingfan zhemingfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zhemingfan zhemingfan merged commit 6b6dc65 into develop_v3 Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Pysam
3 participants