-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/v3 pysam upgrade #266
Conversation
Codecov Report
@@ Coverage Diff @@
## develop_v3 #266 +/- ##
==============================================
+ Coverage 86.66% 86.70% +0.03%
==============================================
Files 53 53
Lines 8843 8897 +54
Branches 2234 2310 +76
==============================================
+ Hits 7664 7714 +50
- Misses 719 722 +3
- Partials 460 461 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Cherry-picks the commits in the other PR onto the develop_v3 branch (#264)
BugFixes
Breaking Changes
Looks like a lot of the issues with the vcf reading part of pysam in later versions boils down to poor support for SVs in the underlying samtools/bcftools. There are some checks going on that make sense for indels/snps but break for SVs. Unfortunately this applies to all versions of pysam after 0.15.2. This short term solution is a drop-in replacement using pandas so we can bypass those checks.
Note: currently the pandas convert does so row-by-row, we can optimize this to perform these operations in the dataframe itself later if we find the performance lags, I wanted to keep the process as close to the current one as possible for this initial PR