Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/python3.9 10 #267

Merged
merged 14 commits into from
Jan 4, 2022
Merged

Feature/python3.9 10 #267

merged 14 commits into from
Jan 4, 2022

Conversation

creisle
Copy link
Member

@creisle creisle commented Jan 4, 2022

Improvements

  • Upgrade to v2 networkx (to allow python 3.9/3/10)
  • Add python 3.9 and 3.10 to the buld tests
  • Use pyproject.toml and setup.cfg for install (merged from jeremy's branch)

@creisle
Copy link
Member Author

creisle commented Jan 4, 2022

I am debugging why the docker build is failing, something to do with the new toml/setup.cfg it looks like not liking data files

@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #267 (ca06372) into develop_v3 (9b3c72c) will decrease coverage by 0.02%.
The diff coverage is 76.92%.

Impacted file tree graph

@@              Coverage Diff               @@
##           develop_v3     #267      +/-   ##
==============================================
- Coverage       86.70%   86.67%   -0.03%     
==============================================
  Files              53       53              
  Lines            8897     8909      +12     
  Branches         2310     2310              
==============================================
+ Hits             7714     7722       +8     
- Misses            722      726       +4     
  Partials          461      461              
Flag Coverage Δ
unittests 86.67% <76.92%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/mavis/tools/vcf.py 94.32% <50.00%> (-1.33%) ⬇️
src/mavis/schemas/__init__.py 85.00% <60.00%> (-9.12%) ⬇️
src/mavis/assemble.py 90.32% <88.23%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b3c72c...ca06372. Read the comment docs.

@creisle creisle merged commit b14c908 into develop_v3 Jan 4, 2022
@creisle creisle deleted the feature/python3.9-10 branch January 4, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants