Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add normalizer rules for $defs and const #290

Merged
merged 2 commits into from
Jan 4, 2021
Merged

Add normalizer rules for $defs and const #290

merged 2 commits into from
Jan 4, 2021

Conversation

awlayton
Copy link
Contributor

@awlayton awlayton commented Apr 9, 2020 •
edited
Loading

This adds support for newer keywords which have previous equivalents:

  • $defs is mapped to definitions
  • const is mapped to a singleton enum

@bcherny
Copy link
Owner

bcherny commented May 2, 2020

Thanks for the contribution! Mind adding some basic tests to make sure this doesn’t regress in the future?

bcherny
bcherny requested changes May 2, 2020
View reviewed changes
Copy link
Owner

@bcherny bcherny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests

@awlayton awlayton requested a review from bcherny May 7, 2020 23:46
@MaikuMori
Copy link

It would be nice to have this merged since other tooling has already moved to https://json-schema.org/draft/2019-09/schema.

@edzis
Copy link

edzis commented Jul 29, 2020

@bcherny Are the tests fine?

bcherny
bcherny approved these changes Dec 19, 2020
View reviewed changes
Copy link
Owner

@bcherny bcherny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you for the contribution!

bcherny
bcherny requested changes Dec 19, 2020
View reviewed changes
Copy link
Owner

@bcherny bcherny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind rebasing? Then I'll go ahead and merge.

@bcherny bcherny mentioned this pull request Dec 19, 2020
Closed
@awlayton awlayton requested a review from bcherny January 4, 2021 18:14
bcherny
bcherny approved these changes Jan 4, 2021
View reviewed changes
Copy link
Owner

@bcherny bcherny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@bcherny bcherny merged commit ec78099 into bcherny:master Jan 4, 2021
@bcherny bcherny mentioned this pull request Jan 4, 2021
Closed
@johnbillion johnbillion mentioned this pull request Apr 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcherny bcherny bcherny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@awlayton @bcherny @MaikuMori @edzis