-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for deprecated keyword (Fixes #441) #542
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
20b8d92
Initial support for deprecated keyword
iansw246 c3a4afb
Remove unnecessary ?
iansw246 3aa9f16
Fix missing deprecated parameter
iansw246 12a8466
Add e2e test for keyword deprecated
michellejtan 6ced819
extended e2e tet to cover deprecated schema and deprecated:false
TravisChong fc57541
Added description property to each item in e2e test to test interacti…
TravisChong 4f72824
Added description property to another object with a true deprecated i…
michellejtan 135d4b6
Fix whitespace and improve comments
iansw246 25fea05
Simplify generateComment
iansw246 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
export const input = { | ||
"$schema": "http://json-schema.org/draft/2019-09/schema#", | ||
"title": "Example Schema", | ||
"type": "object", | ||
"deprecated": true, | ||
description: '/* comment */', | ||
"properties": { | ||
"firstName": { | ||
"type": "string", | ||
"deprecated": true, | ||
description: '/* nested comment */' | ||
}, | ||
"middleName":{ | ||
"type": "string", | ||
"deprecated": true, | ||
"description": "Hi, my name's Doechii, this will be in a comment" | ||
}, | ||
"lastName":{ | ||
"type": "string", | ||
"deprecated": false, | ||
description: '/* nested comment */' | ||
}, | ||
}, | ||
"additionalProperties": false, | ||
"required": [ | ||
"firstName" | ||
] | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be great to contribute this to the upstream
@types/json-schema
typings, since this isn't JSTT-specific.