Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix incorrect variable name and missing TTL in Cache_redis #6166

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

tomek-artneo
Copy link

There is a little bug, which causes warning. Entire method uses $data variable, but in conditional check, there is $value. Leftover from recent updates.

@tomek-artneo tomek-artneo changed the title fix incorrect variable name in Cache_redis get() method fix incorrect variable name and missing TTL in Cache_redis Oct 25, 2022
@tomek-artneo
Copy link
Author

I have also added setting expire time for cached items inside save method. TTL wasn't handled at all.

@rickhewes
Copy link

Would be great to get this merged!

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants