Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Revert to ubuntu base image for adept_loan_mgt #14

Merged
merged 10 commits into from
Jan 20, 2024

Conversation

bcliang
Copy link
Owner

@bcliang bcliang commented Jan 20, 2024

From #13, the Dockerfile missed copying the utility software for managing ADE loans (adept_loan_mgt) over from the builder image. After inclusion, the utility was present but not functional due to uncaught segmentation faults. For now, I wasn't able to resolve the errors.

This PR reverts the release container back to ubuntu jammy. The alpine flavor will continue to be built by the github action (including the compiled adept_loan_mgt utility), but the segmentation fault issues remain unresolved.

Fixes:

  • Add the adept_loan_mgt utility to the published container

Changes:

  • Dockerfiles for both ubuntu and alpine
  • Update github action to build both ubuntu and alpine images
  • Pull latest master from mainline (currently tagged to 0.8.4):
    • improved HTTP response handling
    • some OS-specific changes for windows / android)

Side-effect:

  • The extracted container size has increased due to the base image (19.5MB vs. 88.3MB)

@bcliang bcliang merged commit 573f00d into main Jan 20, 2024
@bcliang bcliang deleted the check-alpine-segfaults branch January 20, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant