This repository has been archived by the owner on Sep 11, 2019. It is now read-only.
Rewriting integration test fixes #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
reviewed
Sep 10, 2019
| rewrite_integration_tests(integration_test_dirs, checkout_path, collection_dir, namespace, collection, spec) | ||
| except yaml.composer.ComposerError as e: | ||
| logger.error(e) | ||
| rewrite_integration_tests(integration_test_dirs, checkout_path, collection_dir, namespace, collection, spec) |
There was a problem hiding this comment.
Why did you remove the error handling?
webknjaz
approved these changes
Sep 11, 2019
bcoca
reviewed
Sep 11, 2019
| @@ -23,9 +22,16 @@ | |||
| from logzero import logger | |||
|
|
|||
| from baron.parser import ParsingError | |||
| from ruamel.yaml import YAML | |||
There was a problem hiding this comment.
i'm trying to avoid parsing corner cases by using the same yaml lib as core, I don't care much about retaining formatting but if you really want to i would prefer to do a replace on the source than reconstruct the yaml.
This was referenced Sep 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.