Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for m/48' wallets #238

Closed
abrkn opened this issue Jul 5, 2017 · 3 comments
Closed

Add support for m/48' wallets #238

abrkn opened this issue Jul 5, 2017 · 3 comments
Assignees
@chjj
Labels
enhancement Improving a current feature

Comments

@abrkn
Copy link

abrkn commented Jul 5, 2017 •
edited by bucko13
Loading

Shared wallets in Copay derive using m/48':

While the derivation path format is still similar to BIP44, the root was in order to indicate that these wallets are not discoverable by scanning addresses for funds.

See https://github.com/bitpay/copay#wallet-export-format
@abrkn abrkn changed the title Add support for m/48 wallets Add support for m/48' wallets Jul 5, 2017
@BluSyn BluSyn added the enhancement Improving a current feature label Jul 11, 2017
@BluSyn
Copy link
Collaborator

BluSyn commented Jul 11, 2017

Since the m/48' spec is specifically related to hardware wallets w/ multisig, which is not implemented yet, this is related to #85

@abrkn
Copy link
Author

abrkn commented Jul 15, 2017

There was a typo in my description. The derivation path is used by Copay, not Trezor. I've updated the description. Afaik this is not related to Trezor.

chjj added a commit that referenced this issue Jul 23, 2017
@chjj
hd/wallet: add bip48 arg to prepare for bip48 support. see #238.
9219e23
@bucko13 bucko13 added the enhancement Improving a current feature label Aug 8, 2017
@bucko13 bucko13 added the bounty label Oct 25, 2017
@bucko13 bucko13 added the enhancement Improving a current feature label Nov 21, 2017
@bucko13
Copy link
Contributor

bucko13 commented Oct 30, 2018

FYI: there is a PR currently up that allows bcoin to be used with trezor wallets now and supports ypub: #616 . It's not clear if this will end up getting merged but it's under consideration and the branch has been tested with a Trezor on mainnet for those that are interested! Closing for now.
#616

@bucko13 bucko13 closed this as completed Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chjj chjj

Labels
enhancement Improving a current feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@chjj @BluSyn @abrkn @bucko13