test: document bech32 test vectors #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds additional information about the test vectors pulled from https://github.com/bitcoin/bips/blob/master/bip-0173.mediawiki
This comment has been minimized.
This comment has been minimized.
|
The valid test cases above this are also from the BIP173 specification test vectors. Also, for what it's worth, several of these vectors are also included in bstring at https://github.com/bcoin-org/bstring/blob/master/test/bech32-test.js |
|
Updated to better document the fact that all of the test cases are taken from the test vectors in bip173. |
braydonf
approved these changes
Mar 26, 2019
braydonf
added a commit
that referenced
this pull request
Apr 5, 2019
test: document bech32 test vectors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds additional information about the bech32 test vectors.
Updated to document both the valid and invalid test cases.
Pulled from https://github.com/bitcoin/bips/blob/master/bip-0173.mediawiki