Use textarea for query header to make it easier to editing long title #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argonism
changed the title
argonism
commented
Sep 23, 2024
Comment on lines
-33
to
+30
| <input className="QueryHeader-inputTitle" type="text" value={query.title} onChange={handleChangeTitle} /> | ||
| <QueryHeaderTitle title={query.title} onChangeTitle={onChangeTitle} /> |
There was a problem hiding this comment.
I've split query header title into new component for readability.
argonism
commented
Sep 23, 2024
Comment on lines
-18
to
+9
| position: absolute !important; | ||
| right: 10px; | ||
| top: 6px; | ||
| margin: auto 10px auto 20px; |
There was a problem hiding this comment.
Use flexbox over position-absolute not to overlap between query header title and select element.
|
Thank you for reviewing! Is there anything I can do for further process? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a working code for #274
With this implementation, query title will behave like this:
output.mp4