Skip to content

Commit

Permalink
Merge branch 'VID-677'
Browse files Browse the repository at this point in the history
  • Loading branch information
dthies committed Jul 31, 2023
2 parents f720c60 + 9376963 commit 2cfce65
Show file tree
Hide file tree
Showing 6 changed files with 22 additions and 33 deletions.
18 changes: 6 additions & 12 deletions .github/workflows/moodle-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,22 +29,16 @@ jobs:
matrix:
include:
- php: '8.0'
moodle-branch: 'MOODLE_401_STABLE'
moodle-branch: 'master'
database: 'pgsql'
- php: '8.0'
moodle-branch: 'MOODLE_401_STABLE'
moodle-branch: 'master'
database: 'mariadb'
- php: '8.0'
moodle-branch: 'MOODLE_400_STABLE'
moodle-branch: 'MOODLE_402_STABLE'
database: 'pgsql'
- php: '7.4'
moodle-branch: 'MOODLE_311_STABLE'
database: 'mariadb'
- php: '7.4'
moodle-branch: 'MOODLE_310_STABLE'
database: 'pgsql'
- php: '7.3'
moodle-branch: 'MOODLE_39_STABLE'
- php: '8.0'
moodle-branch: 'MOODLE_402_STABLE'
database: 'mariadb'

steps:
Expand Down Expand Up @@ -107,7 +101,7 @@ jobs:
run: moodle-plugin-ci mustache

- name: Grunt
if: ${{ matrix.moodle-branch == 'MOODLE_401_STABLE' }}
if: ${{ matrix.moodle-branch == 'MOODLE_402_STABLE' }}
run: moodle-plugin-ci grunt

- name: PHPUnit tests
Expand Down
6 changes: 1 addition & 5 deletions classes/external/external.php
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,7 @@

namespace mod_videotime\external;

defined('MOODLE_INTERNAL') || die();

require_once($CFG->libdir.'/externallib.php');

use external_api;
use core_external\external_api;

/**
* Web service and ajax functions.
Expand Down
14 changes: 6 additions & 8 deletions classes/external/get_videotime.php
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,12 @@

namespace mod_videotime\external;

defined('MOODLE_INTERNAL') || die();

use external_api;
use core_external\external_api;
use core_external\external_function_parameters;
use core_external\external_single_structure;
use core_external\external_value;
use mod_videotime\videotime_instance;

require_once($CFG->libdir.'/externallib.php');
require_once($CFG->dirroot.'/mod/videotime/lib.php');

/**
* Get videotime instance object for cm.
*/
Expand All @@ -43,8 +41,8 @@ trait get_videotime {
* @return external_function_parameters
*/
public static function get_videotime_parameters() {
return new \external_function_parameters([
'cmid' => new \external_value(PARAM_INT, 'Course module ID', VALUE_REQUIRED)
return new external_function_parameters([
'cmid' => new external_value(PARAM_INT, 'Course module ID', VALUE_REQUIRED)
]);
}

Expand Down
10 changes: 6 additions & 4 deletions classes/external/view_videotime.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,12 @@

defined('MOODLE_INTERNAL') || die();

use external_api;
use core_external\external_api;
use core_external\external_function_parameters;
use core_external\external_single_structure;
use core_external\external_value;
use mod_videotime\videotime_instance;

require_once($CFG->libdir.'/externallib.php');
require_once($CFG->dirroot.'/mod/videotime/lib.php');

/**
Expand All @@ -43,8 +45,8 @@ trait view_videotime {
* @return external_function_parameters
*/
public static function view_videotime_parameters() {
return new \external_function_parameters([
'cmid' => new \external_value(PARAM_INT, 'Course module ID.')
return new external_function_parameters([
'cmid' => new external_value(PARAM_INT, 'Course module ID.')
]);
}

Expand Down
2 changes: 1 addition & 1 deletion classes/plugininfo/videotimeplugin.php
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public function available_updates() {
$info = array(
'maturity' => MATURITY_STABLE,
'release' => '1.7.1',
'version' => 2023011202,
'version' => 2023050100,
);
break;
case 'repository':
Expand Down
5 changes: 2 additions & 3 deletions version.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@

$plugin->component = 'mod_videotime';
$plugin->release = '1.7.3';
$plugin->version = 2023011207;
$plugin->incompatible = 402;
$plugin->requires = 2015111610;
$plugin->version = 2023050101;
$plugin->requires = 2023042400;
$plugin->maturity = MATURITY_STABLE;

0 comments on commit 2cfce65

Please sign in to comment.