forked from stardog-union/pellet
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hook for providing project id in the header of every request #29
Open
rgrinberg
wants to merge
13
commits into
master
Choose a base branch
from
interceptor-project-id
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The project id can now be added by initing the client module with an appropriate provider that fetches the current project id. For example, from the client state.
rgrinberg
force-pushed
the
interceptor-project-id
branch
from
July 24, 2017 08:41
67d6ecc
to
ad6ad71
Compare
rgrinberg
force-pushed
the
interceptor-project-id
branch
from
July 24, 2017 09:04
a0139ce
to
727e0b0
Compare
OK I almost made this prototype work. I'm not really convinced this is the right idea though so I really would like to talk about this before proceeding further. The only thing that remains here is stripping off the project Id's before passing them to protege but all this really shows how fragile this entire approach is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project id can now be added by initing the client module with an appropriate
provider that fetches the current project id. For example, from the client state.