any reason for removing 'join' method on Lumberjack::Device::Writer::Buffer ?

[ewamarciniak]

In the most recent version 1.0.13 the join method, which I have been using is no longer supported. Was that removed on purpose?

[bdurand]

In the last release I optimized the thread synchronization to reduce lock contention. There was no particular reason to remove `join` other than it wasn't being used internally anymore (and I didn't think anyone had poked that deeply into the internals of the gem!). Internally, it now uses `pop!` to fetch and clear the array so that the join operation doesn't block other threads from writing to the log. There was another similar change to remove the UTF-8 coercion from the Buffer `<<` method for the same reason. What's your use case for using `join`? It's certainly simple enough to restore that method. The UTF-8 coercion, would not be so simple to restore without reverting the threaded performance boosts.

…

On Apr 3, 2018, at 7:26 AM, Ewa Marciniak ***@***.***> wrote: In the most recent version 1.0.13 the join method, which I have been using is no longer supported. Was that removed on purpose? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#32>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AACjPxBNxtD2pCE4ycRln8CapL4TtXIgks5tk4aGgaJpZM4TFLT5>.