Remove base64 dependency and exclude newlines #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdurand
approved these changes
Apr 4, 2023
|
The issues with ruby 2.4/2.5 specs failing will be fixed with #21. Going to merge this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, Ruby's
Base64.encode64function is implemented following RFC 2045 which adds newlines every 60 characters. This is kinda silly and was superseded in RFC 4648 which instead recommends only adding newlines if the underlying storage (e.g. MIME headers) strictly requires it.Because the
encode64anddecode64functions are just super lightweight wrappers around the underlying string packing calls, pack the data directly and specify"m0"for encoding which tells the packing to never add newlines.All of the data is used entirely internally, so this should be safe to bump as a patch version.