Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saltire part in HEAVY CIRCLED SALTIRE (U+2B59) is off-center (i.e. effectively broken) under Quasi-Proportional. #2528

Closed
jmcwilliams403 opened this issue Oct 4, 2024 · 1 comment · Fixed by #2530
Labels

Comments

@jmcwilliams403
Copy link
Contributor


Monospace for comparison:
image
Aile:
image
It also appears broken in the website specimen:
image

@Logo121
Copy link
Contributor

Logo121 commented Oct 4, 2024

i don't have time to make a pr, but looks like this is the problem:

dispiro [widths.center GeometryStroke] [flat leftFW topFW] [curl rightFW bottomFW]
dispiro [widths.center GeometryStroke] [flat leftFW bottomFW] [curl rightFW topFW]

i guess leftFW and rightFW are not the correct values for these (replace with (df.middle - sqaureRadiusFW) and (df.middle + sqaureRadiusFW)), but considering they are defined as

define leftFW : 0 + SB * MosaicWidthScalar
define rightFW : MosaicWidth - SB * MosaicWidthScalar

i would assume that even if the saltire is not orthogonal, it would be centered at least.

in my local build: (Aile/Etoile is extended so it looks like the middle cases)
image
is the MosaicWidth value not accurate for extended/condensed versions?

@be5invis be5invis linked a pull request Oct 5, 2024 that will close this issue
be5invis added a commit that referenced this issue Oct 5, 2024
* Fix broken shape of certain power and playback symbols under quasi-proportional (#2528).

* Fix alignment of the suit part of Playing Cards glyphs under quasi-Proportional (#2529).
@be5invis be5invis closed this as completed Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants