build: fix TypeScript version #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpf500
force-pushed
the
build/fix-ts-version
branch
from
efdc8a4 to
b529e4f
Compare
…cies build: update dependencies
JumpLink
approved these changes
Jan 2, 2025
There was a problem hiding this comment.
LGTM 👍
This PR includes (including the Merged PR in this PR):
- Dependency updates across the stack (backend, frontend, e2e tests)
- ESLint configuration improvements for TypeScript/Vue
- Minor Vue component refactoring (v-model bindings, unused code removal)
- TypeScript version bump to 5.6.3
Changes look safe and maintainable. I made sure that the test suite is successful before the merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeScript doesn't follow semantic versioning (microsoft/TypeScript#14116). This means things can break on minor version changes. This happened with
vue-tsc(vuejs/language-tools#5020), which currently doesn't seem to support TS 5.7. When I fixed thisvue-tscstarted reporting errors, it seems it was silently failing before.This PR fixes our TypeScript version to patch upgrades only, and fixes the tiptap type errors. To do this I removed the explicit tiptap dependencies which are loaded via the starter kit, and I also had to regenerate the
yarn.lockfile to propagate the version changes.This of course means all our dependencies have potentially upgraded by minor or patch version, which should be fine, but will need some testing. Maybe there is a way of just partially updating the lock file just for tiptap related dependencies that I'm not aware of?