Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): client copied from telegram-bot repo #91

Merged
merged 67 commits into from
Dec 19, 2024
Merged

Conversation

JumpLink
Copy link
Collaborator

@JumpLink JumpLink commented Nov 22, 2024

This is in preparation for API tests, and it's also good to have the client part of the repository so that its codebase does not become orphaned.

  • Copied client package from telegram-bot repo
  • Upgarde Deno to 2.1.1
  • Removed .github/workflows/common-check.yml since its scripts (and the client scripts) are also run with yarn check and yarn test
  • check.yml adapted so that all tests are also executed in it
  • I have removed the browser export from the package.json in the client and in common again. The browser build is bundled and therefore works without dependencies, but if you use a package.json, you are most likely using something that can resolve dependencies and then ESM is the better choice anyway.

@JumpLink JumpLink marked this pull request as ready for review November 22, 2024 13:09
.github/workflows/check.yml Outdated Show resolved Hide resolved
@@ -12,7 +12,7 @@
"serve": "vite preview",
"i18n": "node scripts/i18n.cjs $(git rev-parse --symbolic-full-name --abbrev-ref HEAD)",
"check": "yarn check:vue-tsc && yarn check:eslint && yarn check:prettier",
"check:vue-tsc": "vue-tsc --noEmit",
"check:vue-tsc": "node ../../node_modules/vue-tsc/index.js --noEmit",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this change necessary?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was due to deno because it also stored the package.json packages in the node_modules folder. Should no longer be necessary with the removal of deno

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is related to this vuejs/language-tools#5020, I'll leave the temporary fix in for now.

@wpf500
Copy link
Member

wpf500 commented Dec 5, 2024

I'm just leaving comments here for reference, I will merge this PR regardless. However I think I will remove the extra steps in the check action as it feels a bit excessive in terms of energy usage. To discuss at a later date

@wpf500
Copy link
Member

wpf500 commented Dec 19, 2024

I fixed the Express problem. I think it's because a new version of Express was released recently and some of the @type dependencies were bound to * rather than ^4, so they upgraded themselves to incompatible types

@wpf500 wpf500 merged commit 505972f into main Dec 19, 2024
1 check passed
@wpf500 wpf500 deleted the feat/client branch December 19, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants