-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(client): client copied from telegram-bot repo #91
Conversation
…tests feat: E2E API Test
@@ -12,7 +12,7 @@ | |||
"serve": "vite preview", | |||
"i18n": "node scripts/i18n.cjs $(git rev-parse --symbolic-full-name --abbrev-ref HEAD)", | |||
"check": "yarn check:vue-tsc && yarn check:eslint && yarn check:prettier", | |||
"check:vue-tsc": "vue-tsc --noEmit", | |||
"check:vue-tsc": "node ../../node_modules/vue-tsc/index.js --noEmit", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this change necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this was due to deno because it also stored the package.json packages in the node_modules folder. Should no longer be necessary with the removal of deno
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is related to this vuejs/language-tools#5020, I'll leave the temporary fix in for now.
I'm just leaving comments here for reference, I will merge this PR regardless. However I think I will remove the extra steps in the check action as it feels a bit excessive in terms of energy usage. To discuss at a later date |
feat(client): Port frontend api methods to client
I fixed the Express problem. I think it's because a new version of Express was released recently and some of the |
This is in preparation for API tests, and it's also good to have the client part of the repository so that its codebase does not become orphaned.
.github/workflows/common-check.yml
since its scripts (and the client scripts) are also run withyarn check
andyarn test
check.yml
adapted so that all tests are also executed in it