Update Mailgun.deliver to return ok/error tuples #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
germsvel
added
adapter
|
This one is also failing on a missing |
This was referenced Feb 18, 2021
What changed? ============== Updates Mailgin.deliver function to return ok/error tuples to abide by the new api. Note on raising configuration errors ----------------------------------- We do not change the raising of errors when they deal with configuration options. Those errors are categorically different. We want to return ok/error tuples when there's an error building/delivering email. If a user of Bamboo is missing a configuration variable, it seems important to raise an error.
germsvel
force-pushed
the
gv-mailgun-new-deliver
branch
from
36310ab
to
d559f0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires: #571
What changed?
Updates Mailgin.deliver function to return ok/error tuples to abide by the new api.
Note on raising configuration errors
We do not change the raising of errors when they deal with configuration options. Those errors are categorically different. We want to return ok/error tuples when there's an error building/delivering email. If a user of Bamboo is missing a configuration variable, it seems important to raise an error.