Fix LocalAdapter.deliver/2 return type #589
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #588
Fix the
LocalAdapter.deliver/2
to return a{:ok, result}
tuple whenthe adapter is configured with the
open_email_in_browser_url
option.This does not include a test as I could not come up with a way to test the local adapter with out it attempting a
System.cmd
call and trying to open a file/browser window while running the tests.Any suggestions there would be appreciated.
I was looking at adding the test to the
Bamboo.Adapters.LocalAdapterTest
like the following:The above results in a message being logged while running the tests: "The file $filename does not exist."