-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/user registration #18
Conversation
field :confirmed_at, :naive_datetime | ||
field :first_name, :string | ||
field :last_name, :string | ||
field :country, :string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we've not discussed db strucure, but I would suggest we have an accounts table
this is too much info for a users table
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay , I will wait for the db structure discussion at 6 pm then restructure accordingly
@MICHAELMUNAVU83 This is a good job, especially the UI 👍 I believe this fixes 3 issues at hand:
Kindly ensure that when moving this issue on the board, you also move its associated issues. @75pollet WDYT? My other take though not mandatory you can always share a gif or screenshot when a PR involves UI. Also, I noticed you improved our test coverage to
I will hold my approval until the DB structure is agreed upon, but everything is great and looks good to me as it is |
Fixes #5
In the pull request below , the following tasks were done .