Add some unit tests for get_price_jobs_up_to_date. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please let me know what you think about the TODOs in the tests. If those are intended behaviors, I can update the comments explaining why. If those are not intended behaviors, I can fix them in this or followup PR. |
doriath
force-pushed
the
get_price_jobs_up_to_date_tests
branch
2 times, most recently
from
77e03fa
to
c874c8a
Compare
doriath
force-pushed
the
get_price_jobs_up_to_date_tests
branch
from
c874c8a
to
cf13c5e
Compare
|
Refs #5 |
doriath
force-pushed
the
get_price_jobs_up_to_date_tests
branch
from
cf13c5e
to
faf3e92
Compare
There are two behaviors I am not sure if they are features or bugs. 1. get_price_jobs_at_date() does not return a price for a date when commodity first appears in a transaction (maybe off by one error?). 2. get_price_jobs_(up_to|at)_date() behave differently for commodities not held at cost. If this is a bug, I can fix it in this or followup PR.
doriath
force-pushed
the
get_price_jobs_up_to_date_tests
branch
from
faf3e92
to
47d486b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two behaviors I am not sure if they are features or bugs.
commodity first appears in a transaction (maybe off by one error?).
not held at cost. If this is a bug, I can fix it in this or followup
PR.