Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make a new release to really fix backwards compatibility #45

Closed
ThomasWaldmann opened this issue Jul 3, 2014 · 4 comments
Closed

make a new release to really fix backwards compatibility #45

ThomasWaldmann opened this issue Jul 3, 2014 · 4 comments

Comments

@ThomasWaldmann
Copy link

It seems that a incompatible change of parsedatetime breaks MoinMoin wiki's fullsearch action on debian jessie.

There was already issue #11 and it was closed as fixed (and i can confirm that with repo code it is fixed), but you still need to get the stuff released to really fix it for release users (== most people).

Also, please update the changelog and point out that 1.3 fixes that backwards compatibility issue.

Python 2.7.6 (default, Mar 22 2014, 22:59:56) 
[GCC 4.8.2] on linux2

>>> from parsedatetime.parsedatetime import Calendar
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ImportError: No module named parsedatetime

>>> import parsedatetime.parsedatetime as pdt
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ImportError: No module named parsedatetime

>>> from parsedatetime import Calendar

>>> import parsedatetime
>>> parsedatetime.__version__
'1.2'
@livibetter
Copy link
Contributor

I just hit the same bug and spent an hour to figure out what's going on. I saw there is parsedatetime/parsedatetime.py, couldn't understand why the import doesn't work until I unpacked the two tarballs of v1.1.2 and v1.2, the file is missing in v1.2.

Whatever projects is using the same import as seen in README.md will fail with v1.2 for sure. You will also need to update it, so the newer projects wouldn't use that import -- and break when that backward support eventually gets removed one day -- but one in PyPI:

import parsedatetime as pdt

#43 is asking for tagging v1.3 probably for the same reason.

@bear
Copy link
Owner

bear commented Jul 8, 2014

done

@bear bear closed this as completed Jul 8, 2014
@ThomasWaldmann
Copy link
Author

thanks!

@bear
Copy link
Owner

bear commented Jul 8, 2014

Your welcome! Thanks for using the lib and making it better.
On Jul 8, 2014 6:51 PM, "ThomasWaldmann" notifications@github.com wrote:

thanks!


Reply to this email directly or view it on GitHub
#45 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants