fix date interpretation when day is also provided (#165) #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
gah - sorry about the error that is failing this build... i'll take a look at the PR tonight |
Current coverage is 76.92% (diff: 100%)@@ master #178 diff @@
==========================================
Files 14 14
Lines 1567 1569 +2
Methods 0 0
Messages 0 0
Branches 288 288
==========================================
+ Hits 1205 1207 +2
Misses 268 268
Partials 94 94
|
|
Reviewed 1 of 2 files at r1, 1 of 1 files at r2. Comments from Reviewable |
This was referenced Aug 23, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a scenario previously reported as #165, in which the date is parsed incorrectly when a day is provided (e.g. "tuesday august 23nd 2016 at 5pm"). This particular fix works by ignoring the day if the date is already parsed out - it might be more informative to actually compare the reference date to the parsed out day and log or produce an error if they're not consistent.
This change is